Skip to content

Converter: preset L's message names 310.5 as the minimum version - #107

Merged
phantoslayer21 merged 1 commit into
mainfrom
model-l/converter-l-version
Nov 13, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
model-l/converter-l-version

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

Model L (#89): the player's message for a DLSS file without a preset-L model now names the confirmed minimum version.

  • clean/converter/src/api.cpp kMsgNoPresetL: "This DLSS file has no preset-L model. Version 310.5 or newer is
    needed." It was the provisional 310.9 added in Converter: preset L in the preset table, with a synthetic two-preset test #94. 310.5 is the first DLSS version confirmed to carry a preset-L model
    (spec preset-L confirmation). The "provisional" comment is gone.
  • clean/converter/README.md: the exit-code row says the same, without the "provisional" note.
  • tests/run_tests.py (test_preset_l) and tests/unit_tests.cpp check the full message text.

Independent of #106 (the preset-L map). Either can merge first.

Refs #89

Tested

Run locally on Windows, CPU only, Ninja Release /MT with MSVC, on main e6500a8 plus this commit.

  • Converter ctest (unit, decompression-vectors, synthetic, synthetic5): 4/4 passed.
  • run_tests.py: 4481 checks passed, 0 failed (the same checks as main, with the new message text).
  • M, K and F outputs byte-identical: 1615 output files of the existing synthetic cases, SHA-256 identical to main's.
  • python tools/ci/check_line_endings.py: 1159 files, 0 problems. Public gates (secrets, personal data, licence,
    chunks) pass.

Not tested

  • A real DLL; the launcher (it shows the converter's message as it is); no GPU, no game.

310.5 is the first DLSS version confirmed to carry a preset-L model (it replaces
the provisional 310.9). The message, its README row and the tests that check its
full text follow.

Refs #89

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 13, 2026 23:21
@phantoslayer21
phantoslayer21 merged commit 18b096c into main Nov 13, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the model-l/converter-l-version branch November 13, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant