Repository navigation
Converter: preset L's message names 310.5 as the minimum version - #107
Merged
Merged
Conversation
310.5 is the first DLSS version confirmed to carry a preset-L model (it replaces the provisional 310.9). The message, its README row and the tests that check its full text follow. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model L (#89): the player's message for a DLSS file without a preset-L model now names the confirmed minimum version.
clean/converter/src/api.cppkMsgNoPresetL: "This DLSS file has no preset-L model. Version 310.5 or newer isneeded." It was the provisional 310.9 added in Converter: preset L in the preset table, with a synthetic two-preset test #94. 310.5 is the first DLSS version confirmed to carry a preset-L model
(spec preset-L confirmation). The "provisional" comment is gone.
clean/converter/README.md: the exit-code row says the same, without the "provisional" note.tests/run_tests.py(test_preset_l) andtests/unit_tests.cppcheck the full message text.Independent of #106 (the preset-L map). Either can merge first.
Refs #89
Tested
Run locally on Windows, CPU only, Ninja Release
/MTwith MSVC, on main e6500a8 plus this commit.ctest(unit, decompression-vectors, synthetic, synthetic5): 4/4 passed.run_tests.py: 4481 checks passed, 0 failed (the same checks as main, with the new message text).python tools/ci/check_line_endings.py: 1159 files, 0 problems. Public gates (secrets, personal data, licence,chunks) pass.
Not tested