Repository navigation
Launcher: the MinGW build of WrongGPU and the suite's --only (#219) - #227
Merged
phantoslayer21 merged 3 commits intoNov 15, 2026
Merged
Conversation
llvm-mingw's headers lack four things the launcher uses: the HighQualityCubic WIC interpolation mode, the Gaussian blur optimization values, the UI Automation "no scroll" percent, and __uuidof for IAccPropServices and CAccPropServices (their IIDs are in oleacc.h). Each gets a fallback with the Windows SDK's documented value: the enum values under __MINGW32__, the macro under #ifndef, and __CRT_UUID_DECL with the IIDs oleacc.h already defines. The Windows SDK (MSVC) builds see none of them. Verified: a WRONGGPU_TESTING MinGW build of the WrongGPU target links WrongGPU.exe (it failed with 4 compile errors and 2 link errors before). Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The test built only the launcher's unit tests, so a MinGW build break in the window's code (see the previous commit) went unnoticed. It now builds the WrongGPU target too (built, not run: the window needs a display). The table line in clean/linux/README.md says so. Verified: with a header name removed on purpose the launcher test fails naming the compile error; with it restored the build step passes. Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
main() gave synth_f to the rr test only, so --only re9 (and direct_rr) failed at the call with a missing argument. The dispatch now passes (t, opti, third) cut to the arguments the test function declares, where third is --baseline for the test that takes a baseline installer and the shared-model folder otherwise. That also lets --only slot and --only basics run. The file stays under the 256 KB scan limit (262075 -> 262132 bytes). Verified: the file parses; a check over every test_* signature in the file finds each declared argument bound to the value of that name; check_source_size.py reports 262132 bytes. Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
phantoslayer21
approved these changes
Nov 15, 2026
phantoslayer21
left a comment
Owner
There was a problem hiding this comment.
Checked the four fallback values against the Windows SDK: WICBitmapInterpolationModeHighQualityCubic = 4, D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY = 2, UIA_ScrollPatternNoScroll = -1.0, and the IAccPropServices / CAccPropServices GUIDs all match. They're MinGW-only, so MSVC builds don't change. The --only dispatch works for rr, re9 and the plain tests. Merging once CI is green.
3 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes and why
The "Also" items of #219. Three commits; each stands alone on
main.WrongGPUtarget builds with llvm-mingw 20261104 again. Its headers lack four things the window code uses. Each gets a fallback that only a MinGW build sees, with the Windows SDK's documented value:WICBitmapInterpolationModeHighQualityCubic(4),D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY(2),UIA_ScrollPatternNoScroll(-1.0, a double), and__CRT_UUID_DECLforIAccPropServices/CAccPropServiceswith the IIDs fromoleacc.h. MSVC builds compile none of it.clean/linux/run_wine_tests.py --tests launcheralso builds theWrongGPUtarget, so a MinGW build break in the window code fails the test. It is built, not run.clean/linux/README.mdsays so.--onlypasses each test the arguments it declares.main()gavesynth_ftorronly, so--only re9and--only direct_rrfailed at the call. The dispatch now cuts(t, opti, third)to the function's declared arguments, wherethirdis--baselinefor the test that takes one and the shared-model folder otherwise.run_launcher_tests.pygoes from 262075 to 262132 bytes, still under the 256 KB limit; Launcher suite: test_re9's uninstall check follows the file-ownership rule (#219) #222 frees about 5 KB there.What each new or substantially changed file is based on
No new files. The fallback values are the Windows SDK's documented ones.
How it was tested
llvm-mingw 20261104,WRONGGPU_TESTING): theWrongGPUtarget links. Before commit 1 it failed with 4 compile errors and 2 link errors.run_wine_tests.py --tests launcherunder GE-Proton 11-11 on this branch: the new build step passes;wg-core-tests,coexist-core-testsandwizard-policy-testspass.launcher-core-testsstops at the Engine.ini (Launcher: Engine.ini selective restore can lose a replacement made after it was read #186) check "held from the read to the write...". Unmodifiedmainat 66c3048 stops at the same check under Wine, so it is not from this branch; I can open an issue for it if useful.test_*signature in the file finds each declared argument bound to the value of that name.check_source_size.pyandreuse lintpass.Checklist
Signed-off-by:line (git commit -s; Developer Certificate of Origin 1.1).REUSE.toml. (No new files.)🤖 Generated with Claude Code