Skip to content

Launcher: the MinGW build of WrongGPU and the suite's --only (#219) - #227

Merged
phantoslayer21 merged 3 commits into
phantoslayer21:mainfrom
j0nsh1n:fix/mingw-launcher-build
Nov 15, 2026
Merged

phantoslayer21 merged 3 commits into
phantoslayer21:mainfrom
j0nsh1n:fix/mingw-launcher-build

Conversation

@j0nsh1n

@j0nsh1n j0nsh1n commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

What this changes and why

The "Also" items of #219. Three commits; each stands alone on main.

  1. The WrongGPU target builds with llvm-mingw 20261104 again. Its headers lack four things the window code uses. Each gets a fallback that only a MinGW build sees, with the Windows SDK's documented value: WICBitmapInterpolationModeHighQualityCubic (4), D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY (2), UIA_ScrollPatternNoScroll (-1.0, a double), and __CRT_UUID_DECL for IAccPropServices / CAccPropServices with the IIDs from oleacc.h. MSVC builds compile none of it.
  2. clean/linux/run_wine_tests.py --tests launcher also builds the WrongGPU target, so a MinGW build break in the window code fails the test. It is built, not run. clean/linux/README.md says so.
  3. --only passes each test the arguments it declares. main() gave synth_f to rr only, so --only re9 and --only direct_rr failed at the call. The dispatch now cuts (t, opti, third) to the function's declared arguments, where third is --baseline for the test that takes one and the shared-model folder otherwise. run_launcher_tests.py goes from 262075 to 262132 bytes, still under the 256 KB limit; Launcher suite: test_re9's uninstall check follows the file-ownership rule (#219) #222 frees about 5 KB there.

What each new or substantially changed file is based on

No new files. The fallback values are the Windows SDK's documented ones.

How it was tested

  • MinGW (llvm-mingw 20261104, WRONGGPU_TESTING): the WrongGPU target links. Before commit 1 it failed with 4 compile errors and 2 link errors.
  • run_wine_tests.py --tests launcher under GE-Proton 11-11 on this branch: the new build step passes; wg-core-tests, coexist-core-tests and wizard-policy-tests pass. launcher-core-tests stops at the Engine.ini (Launcher: Engine.ini selective restore can lose a replacement made after it was read #186) check "held from the read to the write...". Unmodified main at 66c3048 stops at the same check under Wine, so it is not from this branch; I can open an issue for it if useful.
  • With a header name removed on purpose, the launcher test fails naming the compile error; restored, the build step passes.
  • A check over every test_* signature in the file finds each declared argument bound to the value of that name.
  • check_source_size.py and reuse lint pass.
  • Not run: the MSVC build (CI's job).

Checklist

  • I make the clean-room statement of CONTRIBUTING.md for this and all my contributions (required once, in my first pull request). (Made in Launcher: install for Proton games from under Wine #105.)
  • Every commit has a Signed-off-by: line (git commit -s; Developer Certificate of Origin 1.1).
  • New source files carry the SPDX licence line for MIT, or are covered in REUSE.toml. (No new files.)

🤖 Generated with Claude Code

j0nsh1n and others added 3 commits November 14, 2026 18:04
llvm-mingw's headers lack four things the launcher uses: the HighQualityCubic
WIC interpolation mode, the Gaussian blur optimization values, the UI
Automation "no scroll" percent, and __uuidof for IAccPropServices and
CAccPropServices (their IIDs are in oleacc.h). Each gets a fallback with the
Windows SDK's documented value: the enum values under __MINGW32__, the
macro under #ifndef, and __CRT_UUID_DECL with the IIDs oleacc.h already
defines. The Windows SDK (MSVC) builds see none of them.

Verified: a WRONGGPU_TESTING MinGW build of the WrongGPU target links
WrongGPU.exe (it failed with 4 compile errors and 2 link errors before).

Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The test built only the launcher's unit tests, so a MinGW build break in the
window's code (see the previous commit) went unnoticed. It now builds the
WrongGPU target too (built, not run: the window needs a display). The table
line in clean/linux/README.md says so.

Verified: with a header name removed on purpose the launcher test fails
naming the compile error; with it restored the build step passes.

Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
main() gave synth_f to the rr test only, so --only re9 (and direct_rr)
failed at the call with a missing argument. The dispatch now passes
(t, opti, third) cut to the arguments the test function declares, where
third is --baseline for the test that takes a baseline installer and the
shared-model folder otherwise. That also lets --only slot and --only
basics run.

The file stays under the 256 KB scan limit (262075 -> 262132 bytes).

Verified: the file parses; a check over every test_* signature in the file
finds each declared argument bound to the value of that name;
check_source_size.py reports 262132 bytes.

Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@phantoslayer21 phantoslayer21 added this to the 0.6.5 milestone Nov 15, 2026

@phantoslayer21 phantoslayer21 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the four fallback values against the Windows SDK: WICBitmapInterpolationModeHighQualityCubic = 4, D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY = 2, UIA_ScrollPatternNoScroll = -1.0, and the IAccPropServices / CAccPropServices GUIDs all match. They're MinGW-only, so MSVC builds don't change. The --only dispatch works for rr, re9 and the plain tests. Merging once CI is green.

@phantoslayer21
phantoslayer21 merged commit c6ad794 into phantoslayer21:main Nov 15, 2026
9 checks passed
@j0nsh1n
j0nsh1n deleted the fix/mingw-launcher-build branch November 15, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants