Skip to content

Linux runner: link rstrtmgr in the MinGW launcher test build (llvm-mingw) - #291

Merged
phantoslayer21 merged 1 commit into
phantoslayer21:mainfrom
j0nsh1n:fix/linux-runner-llvm-mingw
Nov 20, 2026
Merged

phantoslayer21 merged 1 commit into
phantoslayer21:mainfrom
j0nsh1n:fix/linux-runner-llvm-mingw

Conversation

@j0nsh1n

@j0nsh1n j0nsh1n commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

The Linux runner's README says llvm-mingw works, but its launcher test did not link with it: ld.lld reported undefined RmStartSession, RmRegisterResources, RmGetList and RmEndSession. record.cpp pulls the Restart Manager in with #pragma comment(lib, "rstrtmgr.lib"), which clang and gcc ignore for MinGW targets. llvm-mingw does ship librstrtmgr.a, so the fix names it explicitly in clean/installer/CMakeLists.txt, only for non-MSVC builds and only inside the WRONGGPU_TESTING block, the one place record.cpp uses it. Shipped builds are unchanged.

Checked with llvm-mingw 20261104:

  • wg-core-tests, launcher-core-tests, coexist-core-tests, wizard-policy-tests and WrongGPU link; without the line the four undefined symbols come back.
  • The link commands with WRONGGPU_TESTING=OFF are the same as on main.
  • Not run here: gcc MinGW and MSVC (not available on this machine).

Notes, not changed by this PR: under the system wine 11.21 on a bare prefix, coexist-core-tests and wizard-policy-tests pass. wg-core-tests fails "DetectGpu under Wine: the RDNA 4 card Linux reports" (not investigated; it may need the runner's prefix). launcher-core-tests fails the Engine.ini #186 held-file check, as it already did under Wine on main (seen in #227).

Reviewed before opening by two other models.

Checklist

record.cpp pulls the Restart Manager in with an MSVC-only #pragma comment(lib); clang and gcc for MinGW ignore it,
so the launcher tests failed to link with llvm-mingw (undefined RmStartSession, RmRegisterResources, RmGetList,
RmEndSession), although the Linux runner's README says llvm-mingw works. The library is named explicitly for
non-MSVC builds, inside the WRONGGPU_TESTING block, the only place record.cpp uses it: shipped builds are unchanged.

Verified: wg-core-tests, launcher-core-tests, coexist-core-tests, wizard-policy-tests and WrongGPU now link with
llvm-mingw 20261104 (before: ld.lld undefined symbols); line endings and git diff --check clean.

Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
@phantoslayer21
phantoslayer21 merged commit 8fbf277 into phantoslayer21:main Nov 20, 2026
10 checks passed
j0nsh1n added a commit to j0nsh1n/wronggpu that referenced this pull request Nov 20, 2026
phantoslayer21#293); recompute kSourceDigest on the combined sources

phantoslayer21#290 changed the same kSourceDigest line in clean/k/runtime/k_smx_selfcheck.h.
The value is recomputed with clean/k/dx12/smx_selfcheck_digest.py on the
merged tree (stale() is None; test_k_smx_selfcheck_digest passes). No other
conflict.

Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
j0nsh1n added a commit to j0nsh1n/wronggpu that referenced this pull request Nov 20, 2026
…inux launcher

clean/installer/CMakeLists.txt conflicted with phantoslayer21#291: main links rstrtmgr for
non-MSVC test builds, while this branch already names rstrtmgr for every
WIN32 build of wg_core (record.cpp's #pragma comment(lib) is read by MSVC
only). The branch's version is kept; it covers phantoslayer21#291's case.

Verified: fresh Linux build (WRONGGPU_TESTING=ON, Release, Ninja), ctest
24/24 passed, launcher-native included.

Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
@j0nsh1n
j0nsh1n deleted the fix/linux-runner-llvm-mingw branch November 20, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants