Repository navigation
Linux runner: link rstrtmgr in the MinGW launcher test build (llvm-mingw) - #291
Merged
phantoslayer21 merged 1 commit intoNov 20, 2026
Merged
Conversation
record.cpp pulls the Restart Manager in with an MSVC-only #pragma comment(lib); clang and gcc for MinGW ignore it, so the launcher tests failed to link with llvm-mingw (undefined RmStartSession, RmRegisterResources, RmGetList, RmEndSession), although the Linux runner's README says llvm-mingw works. The library is named explicitly for non-MSVC builds, inside the WRONGGPU_TESTING block, the only place record.cpp uses it: shipped builds are unchanged. Verified: wg-core-tests, launcher-core-tests, coexist-core-tests, wizard-policy-tests and WrongGPU now link with llvm-mingw 20261104 (before: ld.lld undefined symbols); line endings and git diff --check clean. Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
3 tasks done
j0nsh1n
added a commit
to j0nsh1n/wronggpu
that referenced
this pull request
Nov 20, 2026
phantoslayer21#293); recompute kSourceDigest on the combined sources phantoslayer21#290 changed the same kSourceDigest line in clean/k/runtime/k_smx_selfcheck.h. The value is recomputed with clean/k/dx12/smx_selfcheck_digest.py on the merged tree (stale() is None; test_k_smx_selfcheck_digest passes). No other conflict. Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
j0nsh1n
added a commit
to j0nsh1n/wronggpu
that referenced
this pull request
Nov 20, 2026
…inux launcher clean/installer/CMakeLists.txt conflicted with phantoslayer21#291: main links rstrtmgr for non-MSVC test builds, while this branch already names rstrtmgr for every WIN32 build of wg_core (record.cpp's #pragma comment(lib) is read by MSVC only). The branch's version is kept; it covers phantoslayer21#291's case. Verified: fresh Linux build (WRONGGPU_TESTING=ON, Release, Ninja), ctest 24/24 passed, launcher-native included. Signed-off-by: Jonathan Shin <85975340+j0nsh1n@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux runner's README says llvm-mingw works, but its
launchertest did not link with it:ld.lldreported undefinedRmStartSession,RmRegisterResources,RmGetListandRmEndSession.record.cpppulls the Restart Manager in with#pragma comment(lib, "rstrtmgr.lib"), which clang and gcc ignore for MinGW targets. llvm-mingw does shiplibrstrtmgr.a, so the fix names it explicitly inclean/installer/CMakeLists.txt, only for non-MSVC builds and only inside theWRONGGPU_TESTINGblock, the one placerecord.cppuses it. Shipped builds are unchanged.Checked with llvm-mingw 20261104:
wg-core-tests,launcher-core-tests,coexist-core-tests,wizard-policy-testsandWrongGPUlink; without the line the four undefined symbols come back.WRONGGPU_TESTING=OFFare the same as on main.Notes, not changed by this PR: under the system wine 11.21 on a bare prefix,
coexist-core-testsandwizard-policy-testspass.wg-core-testsfails "DetectGpu under Wine: the RDNA 4 card Linux reports" (not investigated; it may need the runner's prefix).launcher-core-testsfails the Engine.ini #186 held-file check, as it already did under Wine on main (seen in #227).Reviewed before opening by two other models.
Checklist
Signed-off-by:line (DCO 1.1).REUSE.toml(no new files).