Repository navigation
Model L: l_post_recon_p12, the reconstruction kernel on pack12 coefficients (HIP + D3D12 port) - #141
Merged
Merged
Conversation
…cients (HIP + D3D12 port) l_post.hip: the kernel body becomes a template on the coefficient form; l_post_recon_p12 reads l_coef_pack12's images (A8, 8 bytes per pixel; C4, 4 bytes; B unused), the same texel values, so the same outputs. l_post.hlsl: the D3D12 port's LP_P12 variant (texel load only; l_post_recon's DXIL is unchanged). l_d3d12_ops_check.py: the reconstruction cases on pack12 inputs, and on HIP the pack12 kernel's raw outputs must equal l_post_recon's. FORMATS.md: the kernel. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com> # Conflicts: # clean/l/runner/l_d3d12_ops_check.py
phantoslayer21
marked this pull request as ready for review
November 14, 2026 04:44
This was referenced Nov 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89
#136 has merged; this branch is current with main.
l_post_recon_p12is Model L's reconstruction kernel on the pack12 coefficients ofl_coef_pack12(#131 / #134), which is the form the D3D12 frame reads. It comes as a HIP kernel plus its D3D12 port.What
clean/l/kernels/l_post.hip: the kernel body becomes a template on the coefficient form.l_post_recon_p12reads image A8 (8 bytes per render pixel: codes A0 A1 A2 B0 | B1 B2, C2 as FP16) and image C4 (4 bytes per render pixel: C0, C1 as FP16).Bis unused (null).l_post_recon, with the same grid and the same outputs.clean/dx12/kernels/l_post.hlsl: theLP_P12variant (texel load only).l_post_recon's DXIL is byte-identical to Model L: D3D12 port of the reconstruction kernel l_post_recon, byte for byte against its HIP kernel #136's (SHA-256).clean/l/runner/l_d3d12_ops_check.py: the 10 reconstruction cases on pack12 inputs. On HIP, the pack12 kernel's raw output bytes must equall_post_recon's for the same cases.clean/l/FORMATS.md: the kernel.GPU record
l_d3d12_ops_check.py --run --seeds 6 --kernels l_post_recon,l_post_recon_p12, one GPU slot, this branch'sl_post.coand DXILs.l_post_recon_p12(HIP vs D3D12)l_post_recon(HIP of this branch vs D3D12)swin_block_c96_ncl_post_recon_p12equalsl_post_reconon HIP: 60 of 60 cases, all output bytes.l_post_recon's HIP machine code (scheduling and encodings; the same arithmetic opcode mix). Its outputs are byte-identical to Model L: D3D12 port of the reconstruction kernel l_post_recon, byte for byte against its HIP kernel #136's D3D12 port on all 60 cases above.l_post.cois Model L's code object).Tested
Not tested