Repository navigation
D3D12: the analytic standalone output filter w64/post_filter_c1_s4 (post_w64.co), byte for byte against HIP - #147
Merged
Conversation
…ost_w64.co), byte for byte against HIP post_filter.hlsl ports filter_strip_c1<4> of post_w64.co (the runtime's default unbanded filter, run after a reconstruction kernel that writes the display image, e.g. Model L's l_post_recon_p12, when the model file has no output-filter weights): the analytic filter of post.hlsl, the 7-row window as named vectors (a shifted local array compiled to a block copy that broke the overlapping shift). post_tf_d3d12_check.py: its cases against HIP post_filter_c1_s4. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as ready for review
November 14, 2026 04:59
This was referenced Nov 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89
D3D12 port of the analytic standalone output filter
w64/post_filter_c1_s4ofpost_w64.co, byte for byte against HIP.This is the runtime's default unbanded filter (
kDefaultFilter). It runs after a reconstruction kernel that writes the display image when the model file has no output-filter weights. With it, the D3D12 frame can run Model L's own reconstructionl_post_recon_p12(#141) followed by this filter.What
clean/dx12/kernels/post_filter.hlsl(new):@wg-kernel w64/post_filter_c1_s4 co=post_w64.co block=64 wave=64, HIP's arguments (display, out, dw, dh, ow, oh, dec_scale, expo) and grid. It is a port offilter_strip_c1<4>:clean/dx12/tests/post_tf_d3d12_check.py: the filter's cases against HIPpost_filter_c1_s4, on the same engine as D3D12: analytic-filter ports of the fused output kernels (post_w64.co), byte for byte against HIP #145.GPU record
post_tf_d3d12_check.py --run --seeds 3 --kernels w64/post_filter_c1_s4,orig_w64/post_tf_f32_p12_diet_vsit, one GPU slot.w64/post_filter_c1_s4(analytic) vs HIPpost_filter_c1_s4(post_w64.co)w64/post_tf_f32_p12_diet_vsit(original filter) vspost_w64__orig.cow64_post_filter_c1_s4_s0_0again with half its workgroups. Caught, 25,272 differing bytes.post_filter.hlsl. Its name is new in the manifest.Tested
Not tested
_directform: HIP has none. The game route with Model L's reconstruction reads the colour from buffers (l_post_recon_p12has no direct form either), so this filter runs on the staged route, with the converter's output pass after it. A direct form can follow if the frame needs it._o16/_houtput forms (RGBA16F output copy).