Repository navigation
Launcher: the Model L choice (set <game> model=L), off by default - #138
Merged
Merged
Conversation
A launcher built with WRONGGPU_MODEL_L (CMake option, default OFF: on only in a release whose front end and runtime run Model L) has a model setting (profile key `model`, values m and l): - `set <game> model=L` is accepted only while Model L's data on this PC (model\L\model.wgcm) passes its check against Model L's converter data; otherwise it is refused with how to convert it (exit 5, nothing changed). - L writes wronggpu.ini's runtime_options (every model item out, model=L last) and OptiScaler.ini's UpscalerIndex ([WrongGPU] in OptiScaler 10's slot, else [FSR]) to Model L's entry: 1, or 2 in a build with Preset K. Both go through the settings apply, so the install record's hashes follow them. - M changes nothing: only Model L's items and an UpscalerIndex naming Model L's entry go back; profile.ini has a model line only for L. - A game saved on L whose data is gone is not refused on an install, repair or update: its files say Model M with a warning, the profile keeps L. Without the option nothing changes anywhere (no setting in the profile, `get` or the JSON); `set <game> model=L` is refused by name (exit 10). The window has no model control yet. Tests: model-choice (new ctest: profile.cpp built with the choice on, added to the CI launcher step), launcher-core (the choice off), and tests/run_model_l_tests.py --launcher-choice end to end. The shadowed local in the Model L message (model.cpp) is renamed. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
force-pushed
the
model-l/model-choice
branch
from
November 14, 2026 15:54
efe8441 to
8e22bc7
Compare
phantoslayer21
marked this pull request as ready for review
November 14, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher side of the Model L choice:
set <game> model=Lin a launcher built withWRONGGPU_MODEL_L(CMake option,default OFF, on only in a release whose front end and runtime run Model L). The front end's Model L entry (registry row,
WG_MODEL_L, model lookup and refusals) is in main since #155. This PR writes the runtime optionmodel=L(the registry'sruntime_optionfor Model L) and selects the entry the front end lists after Model M (and Model K).Based on main; it carries only its own commit. It was first written on top of #47 and is rebased onto main, so it does
not depend on #47.
What changes
wizard_policy.h/ CMake:WRONGGPU_MODEL_L(default 0), private towg_core, the app and the tests that need it.profile.cpp/profile.h:modelsetting (Layer::Model, valuesm,l) exists only with the option. Without it,set <game> model=Lgets
kNoModelChoice("Model L isn't part of this build of WrongGPU ...", exit 10).runtime_optionshas every model item removed andmodel=Ladded last. OptiScaler.ini'sUpscalerIndexis set tokModelLEntryIndex(1, or 2 with Preset K):[WrongGPU]in OptiScaler 10's slot,else
[FSR].modelline only for L.model.cpp/model.h:ModelFileReady(ctx, preset)checks one model's file against that model's embeddedconverter data, whatever model the context has selected.
ModelLNotReadygives the player's lines.launcher.cpp:exit 5, nothing changed).
ApplyProfilerenders a game saved on L as Model M, with a warning, when the data is gone. An install, repair orupdate never fails over it.
model.cpp: the shadowed local in the Model L message is renamed (pickedWhy).model-choiceis built and run in the launcher step.Model M: with the option off nothing changes in any file, list or JSON. With it on, M leaves wronggpu.ini, OptiScaler.ini
and profile.ini as they were.
The entry index follows the registry's list order (M, K, L) from #155 as far as read:
clean/wgshared/REGISTRY.mdlistsModel M, Model K, Model L as entries 0, 1, 2. The index 1 without Preset K assumes the list then omits Model K; that is
this PR's assumption and was not checked against a running front end.
Refs #89
Tested (Windows, CPU only, 1 compile job, on the rebased head)
-DWRONGGPU_TESTING=OFF -DWRONGGPU_PRESET_K=OFF -DWRONGGPU_DIRECT_ROUTE=OFF),built and run locally:
wg-core,launcher-core,coexist-core,convert-ignore,model-choice,source-sizeandwording: 7 of 7 passed.ci.yml's runner versions and timeouts.Not re-run on this head (the end-to-end runs were done on the earlier head, which sat on #47)
tests/run_model_l_tests.py --launcher-choiceand its other launcher builds, the coexist, launcher and installerPython suites.
Not tested