Repository navigation
Model K: the launcher's per-game model choice K and the front end's K build state, off by default - #211
Merged
Conversation
… build state, off by default Launcher: CMake WRONGGPU_MODEL_K (default OFF, needs WRONGGPU_PRESET_K) makes `model` accept k like the Model L choice (set <game> model=K writes wronggpu.ini's model=K last and OptiScaler's UpscalerIndex 1; the data check, the refusal, the repair fallback and the way back to Model M are Model L's). Model L's entry is 2 whenever Model K is built in. Front end: Model K's state is a property of wg_fsr_core like Model L's, so a build with WG_MODEL_K=OFF (releases, CI) also tests a front end with Model K and a build with it ON also tests one without. The default of WG_MODEL_K is unchanged. Tests: model-choice-k (with and without the Model L choice) in CI, tests/run_model_k_tests.py end to end, an L and an M control. BUILDING.md section 8 and the launcher README describe the K build. CI and releases keep Model K off. No other mode of Model K is offered, written or documented. Refs #15 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as ready for review
November 14, 2026 22:50
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #15
Step 10 of the Model K port: the build switches and the launcher's per-game choice. Model K stays off by default for players: the release and CI commands keep K out, and nothing here changes what a player's build contains. K is exact only: no approximation mode is exposed, defaulted or documented (the runtime's
networkandk_fastoptions are not touched and nothing in the launcher or front end sets them).What changes
Launcher (
clean/installer)WRONGGPU_MODEL_K(defaultOFF; configuring it ON withoutWRONGGPU_PRESET_K=ONstops with an error, because Model K's converter map and model folder come with Preset K). It makes the existingmodelsetting acceptk(m|k,m|k|ltogether withWRONGGPU_MODEL_L), done like the Model L choice (Launcher: the Model L choice (set <game> model=L), off by default #138):set <game> model=Kis accepted only while Model K's data on this PC (model\K\model.wgcm) passes its check against Model K's converter data; otherwise exit 5 with Model K's words andmodel convert --preset=K, nothing changed.model=K(every model item out, K last) and OptiScaler.ini'sUpscalerIndex= 1 ([WrongGPU]slot, else[FSR]). The record's hashes follow both writes, as for every settings write.set <game> model=M(the profile says M) puts Model K's item back tomodel=Mand an index naming K's entry back to 0. profile.ini has amodelline only for K and L. A game saved on K whose K data is gone is not refused: its files say Model M, with a warning.WRONGGPU_MODEL_K=OFF(every release and CI build) the code compiles to what it was:model=Kis not a value./PRESET=K) writes no profile, so the profile is imported from the files (model=Kbecomesk). Aprofile.inisaved by a build without the K choice has no model line and says M, so the next settings apply there puts a Model K item back to M. This only exists in development builds with the choice on.set, as for L.Front end (
clean/fsr/CMakeLists.txt)WG_MODEL_Kalready existed (default ON, releases and CI say OFF); its default is unchanged. Its state is now a property ofwg_fsr_core(like Model L's), so a build with K OFF (releases, CI) also tests a front end with Model K (fsr_frontend_model_k_unit,fsr30_hook_model_k_unit) and a build with K ON also tests one without. Standalone ASI targets get the build's value explicitly. I checked every compile unit's-DWRONGGPU_MODEL_Kin an ON and an OFF build (ninja command dump): all product and test units carry the build's value, the variants carry the other.Docs and CI: BUILDING.md section 8 (a build with Model K), the launcher README section. CI keeps
-DWG_MODEL_K=OFFand-DWRONGGPU_PRESET_K=OFF; the launcher job also builds and runs the two new K test executables.Coordination with the ASI fix
Nothing in
clean/fsr/asi/*or the front end's precedence code is touched. What the ASI/precedence work needs from this entry: K ismodel=Klast inruntime_optionsplusUpscalerIndex1 ([WrongGPU]slot, else[FSR]), the same shape as L (2). The plugin'swronggpu-asi.iniselection is not written by the launcher's choice (as for L). profile.cpp: my edits are the K branches beside the existing L branches inkSettings,EffectiveSettings,RenderWronggpuIni,RenderOptiIni; I rebase on the ASI PR if it lands first.Tested
unit|hosted|diagnostic|support, minus overlay/split/d3d12): 18/18 each (one skip: the OptiScaler-binary scan, no binary given), including the other-state variants.WRONGGPU_PRESET_K=OFF):wg-core,launcher-core,coexist-core,convert-ignore,model-choice(the L control, 22 checks, unchanged),model-choice-k(36 checks: K with L, an L and an M control, byte-for-byte M),model-choice-k-only(32 checks),source-size,wording: 9/9.PRESET_K=ON MODEL_K=ON MODEL_L=ON: the same ctest group pluswizard-policy: 10/10.clean/installer/tests/run_model_k_tests.pyagainst that build (generated fixtures, test maps, no game, no GPU): 20/20 — refusal without K data (exit 5, nothing changed), conversion,model=K(ini + index 1 + record hashes + profile), again (no change), back to M byte for byte, the L control (index 2, K to L to M byte for byte), repair without the K data, uninstall (the game folder as before the install, except the plugin's ownwronggpu-asi.inithat a Preset K build seeds and an uninstall deliberately leaves).public_gates.py: must-pass gates pass; LOOK 42 / 29 / 115 (baseline 42 / 29 / 111: the four extra are step and section cross-references in BUILDING.md section 8, not measurements).Not tested
/PRESET=Kinstaller path (unchanged code, covered by the existing installer suite, not re-run).State
Head 0875b34 (main merged in, no conflict, no overlap with this change). CI: both required checks and all 9 jobs green. Main has since gained only an unrelated workflow file (discord-feed.yml); the PR is mergeable (CLEAN). The four extra LOOK lines of the numbers gate are the step and section cross-references in BUILDING.md section 8 ("3.3", "4.1", "5.2", "section 6"), not measurements.