Repository navigation
Launcher: convert Model L by preset name with the preset-L map - #125
Merged
Merged
Conversation
`model convert --preset=L` and `model status --preset=L` select Model L by its name: the launcher embeds data/preset-L.v1.map.json (the spec side's revision v1.1; CMake WRONGGPU_MAP_L, make_payload.py --map-l, resource 903) and loads it as preset L, so a map that names another preset is "converter data damaged". The model goes to %LOCALAPPDATA%\WrongGPU\model\L\model.wgcm with its own model-source.txt, the folder where the runtime looks for model=L (model_select.h). - Context::presetL and SelectPreset(ctx, name): M, L (and K in a build with Preset K), either case; an unknown name, or L in a build without its map, is refused and nothing changes. A different model drops the loaded map. - A file without Model L's data is refused with Model L's words and the converter's reason for the file the player chose (exit 5). An unknown name is a bad command line (exit 10). - The JSON result names the model (`preset`) and the converter map in use (`model.map_sha256`, `model.map_error`). - Model M is unchanged: without --preset the map is loaded as before (no expected preset), and Model M's folder is never touched by a Model L conversion. Tests: launcher-core (selection by name, the folders, refusals); tests/run_model_l_tests.py end to end with a build of the shipped map (status, the map's SHA-256, refusals, Model M untouched) and a build of a test map in the shipped map's exact layout (--write-test-map: the conversion bit-exact, model-source.txt, reuse, Model M byte for byte, and the same Model M bytes as a launcher built from main). Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as draft
November 14, 2026 01:51
phantoslayer21
marked this pull request as ready for review
November 14, 2026 02:10
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher can convert Model L by its preset name.
model convert --preset=Landmodel status --preset=LuseModel L's converter map,
data/preset-L.v1.map.json(the spec side's revision v1.1, from #116), all the way through. Themodel goes to the folder where the runtime looks for
model=L. A file without Model L's data is refused clearly, andModel M stays as it was. This is the first step of the selection path for #89. The window's model choice and the
runtime settings for Model L come in a follow-up.
What changes
WRONGGPU_MAP_L, defaultdata/preset-L.v1.map.json;make_payload.py --map-l, resource 903; empty: a build without Model L).EmbeddedDatagainslMapId/lMapSha256, added at the end so the existing initialisers stay valid.wg_core/context:Context::presetLandSelectPreset(ctx, name). The name is M, L, or K in a build with Preset K,in either case. An unknown name, or L in a build without its map, is refused, and nothing changes. Choosing another
model drops the loaded map.
LoadEmbeddedMaploads Model L's map with the expected preset"L", so a map that names another preset is"converter data damaged". Models M and K load as before, with no expected preset.
ModelDir:%LOCALAPPDATA%\WrongGPU\model\L, the runtime's folder formodel=L(clean/runtime/model_select.h).wg_core/model.cpp: when no file has Model L's data, the message names Model L and gives the converter's reason forthe file the player chose: "Model L can't be prepared: no DLSS model file with Model L's data was found. The file you
chose (...): This DLSS file has no preset-L model. ..." (exit 5). Model M's messages are unchanged.
app/cli.cpp:model status|convert --preset=M|L. An unknown or empty name is a bad command line (exit 10). TheJSON result names the model (
preset) and the converter map in use (model.map_sha256,model.map_error).Model M: without
--presetthe code path is the same as before. A Model L conversion never touches Model M's folder.The tests below check both, including the same Model M bytes from a launcher built from main.
Refs #89
Tested
All runs are on Windows, CPU only, with 1 compile job.
tests/run_model_l_tests.py: aWRONGGPU_TESTINGlauncher built with the shipped preset-L map, one built with a test map in its exact layout (--write-test-map), and a launcher built from main (750a530) with the same payload and test maprun_model_l_tests.pychecks:"preset": "L", a 13-entrydec0_values).status --preset=Lreports the shipped map's SHA-256 andmodel\L\model.wgcm.--preset, Model M with its own map.converter's reason: "not a DLSS model file", and "This DLSS file has no preset-L model".
--preset=Q,ML, an empty name andK(a build without Preset K) give exit 10.model\L\model.wgcm, bit-exact with the reference (every stage, digest and tensor), withits own
model-source.txt(file, map SHA-256, no filter line).file.
launcher-core: selection by name, folders, refusals, dropping the earlier map state.Not tested