Skip to content

Mark pinned toolchain and plugin repos reproducible #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abrisco merged 2 commits into from
Oct 29, 2026
Merged

Mark pinned toolchain and plugin repos reproducible #309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a22a88
Mark pinned toolchain and plugin repos reproducible
sethvargo Oct 28, 2026
0fa21aa
Retrigger CI
sethvargo Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion helm/private/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def _helm_toolchain_repository_impl(repository_ctx):
repository_ctx.name,
))

return {
attrs_for_reproducibility = {
"integrity": results.integrity,
"name": repository_ctx.name,
"platform": repository_ctx.attr.platform,
Expand All @@ -70,6 +70,16 @@ def _helm_toolchain_repository_impl(repository_ctx):
"urls": repository_ctx.attr.urls,
}

# Bazel <8.3.0 lacks repository_ctx.repo_metadata
if not hasattr(repository_ctx, "repo_metadata"):
return attrs_for_reproducibility

reproducible = repository_ctx.attr.integrity != ""
return repository_ctx.repo_metadata(
reproducible = reproducible,
attrs_for_reproducibility = {} if reproducible else attrs_for_reproducibility,
)

helm_toolchain_repository = repository_rule(
implementation = _helm_toolchain_repository_impl,
doc = "A repository rule for generating a Helm toolchain definition",
Expand Down Expand Up @@ -148,6 +158,12 @@ def _helm_plugin_repository_impl(repository_ctx):
repository_ctx.name,
))

# Bazel <8.3.0 lacks repository_ctx.repo_metadata
if not hasattr(repository_ctx, "repo_metadata"):
return None

return repository_ctx.repo_metadata(reproducible = repository_ctx.attr.integrity != "")

helm_plugin_repository = repository_rule(
implementation = _helm_plugin_repository_impl,
doc = "A repository rule for downloading a Helm plugin and generating a helm_plugin target.",
Expand Down Expand Up @@ -303,6 +319,12 @@ def _helm_toolchain_repository_hub_impl(repository_ctx):
toolchain_type = str(repository_ctx.attr.toolchain_type),
))

# Bazel <8.3.0 lacks repository_ctx.repo_metadata
if not hasattr(repository_ctx, "repo_metadata"):
return None

return repository_ctx.repo_metadata(reproducible = True)

helm_toolchain_repository_hub = repository_rule(
doc = (
"Generates a toolchain-bearing repository that declares a set of other toolchains from other " +
Expand Down
Loading