Repository navigation
Mark pinned toolchain and plugin repos reproducible - #309
Merged
abrisco merged 2 commits intoOct 29, 2026
Merged
Conversation
Contributor
Author
|
@abrisco it looks like CI is failing, but I'm not entirely sure why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308.
#286 moved
helm_import_repositorytorepository_ctx.repo_metadata, but the toolchain repos still returned a bare dict. Bazel never put them in the repo contents cache, so every new output base downloaded and extracted helm again.This change makes three rules return
repo_metadata:helm_toolchain_repositoryreproducible = Truewhenintegrityis set, which the extension always does. Without it, the resolved integrity goes inattrs_for_reproducibility, the same as before.helm_plugin_repositoryreproducible = Truewhenintegrityis set. The attribute is mandatory.helm_toolchain_repository_hubreproducible = True. It only writes files from its attributes.helm_host_alias_repositorystays as it is because it readsrepository_ctx.os. All three use the samehasattrguard asimport.bzl, so Bazel 7 still gets the old return values.Testing
On Bazel 9.3.1, I fetched the toolchain,
with_cm_push, and plugin repos for darwin_arm64 into two fresh output bases that shared one--repository_cache. In both output bases, each repo was a symlink to the same repo contents cache entry. Before this change, the toolchain and plugin repos were real directories in every output base.buildifier -mode=check -lint=warnpasses.