Skip to content

hotfix: re-consent modal polish (button squash, bold Not-now, wrapping label) - #2589

Merged
1 commit merged into
mainfrom
hotfix/re-consent-modal-polish
Jul 31, 2026
Merged

hotfix: re-consent modal polish (button squash, bold Not-now, wrapping label)#2589
1 commit merged into
mainfrom
hotfix/re-consent-modal-polish

Conversation

@jjramirezn

@jjramirezn jjramirezn commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Three visual fixes in ReConsentModal only: sm:flex-none on both CTAs (ActionModal's sm:flex-1 is meant for its side-by-side layout and squashed the stacked h-13 buttons), font-normal text-grey-1 on Not-now (every .btn is bold by default), and shorter checkbox copy so it fits one line on mobile.

⚠️ Note for review: checkbox copy changed "I have read and accept the updated documents" → "I accept the updated documents" (drops "have read") — the intro copy still prompts reading and the links precede the box, but it's legal-attestation wording, so judge it consciously.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • UI Improvements
    • Updated the consent checkbox wording for greater clarity.
    • Improved responsive layout and visual styling for consent modal buttons.
    • De-emphasized the “Not now” option with lighter text styling.

ActionModal's sm:flex-1 (built for side-by-side CTAs) squashed the
stacked h-13 buttons; 'Not now' inherited .btn's font-bold and competed
with the primary; the checkbox label wrapped to two lines on mobile.
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview Jul 30, 2026 3:58pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 189a73ac-f4df-423f-9fd3-a0fdb43c61d1

📥 Commits

Reviewing files that changed from the base of the PR and between 4b1b482 and 14eb8db.

📒 Files selected for processing (1)
  • src/components/Global/ReConsentModal/index.tsx

📝 Walkthrough

Walkthrough

The ReConsent modal shortens its consent checkbox text and updates CTA classes and secondary-button styling to maintain stacked responsive presentation and visually de-emphasize “Not now”.

Changes

ReConsent modal

Layer / File(s) Summary
Consent prompt and CTA presentation
src/components/Global/ReConsentModal/index.tsx
The checkbox label now says “I accept the updated documents”; CTA classes prevent side-by-side small-screen layout, and “Not now” uses normal font weight with grey text.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main UI fixes in ReConsentModal, including stacked button styling, Not now emphasis, and the shorter checkbox label.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/re-consent-modal-polish

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 2294 ran, 0 failed, 0 skipped, 40.0s

📊 Coverage (unit)

metric %
statements 62.5%
branches 45.9%
functions 52.2%
lines 62.9%
⏱ 10 slowest test cases
time test
3.7s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
1.4s src/utils/__tests__/demo-api.test.ts › isDemoMode() is false when not running under Capacitor
0.5s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › every sticker stays within canvas at any count
0.3s src/app/actions/__tests__/api-headers.test.ts › should include Content-Type in validateInviteCode
0.3s src/app/actions/__tests__/api-headers-extended.test.ts › should not include apiKey in validateInviteCode body
0.3s src/app/(mobile-ui)/withdraw/__tests__/withdraw-states.test.tsx › Bank withdrawal keeps the $1 minimum for sub-$1 amounts
0.3s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › keeps stickers off the username pill (final pass respects the keep-out)
0.3s src/utils/__tests__/demo-balance.test.ts › keeps a spent-down balance across a cold start within the TTL
0.2s src/utils/__tests__/demo-balance.test.ts › debits and floors at zero
0.2s src/utils/__tests__/demo-balance.test.ts › resetDemoBalance refills and restarts the TTL window
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@github-actions

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 6350.19 → 6350.35 (+0.16)
Findings: 0 net (+2 new, -2 resolved)

🆕 New findings (2)

  • medium complexity — src/components/Global/ReConsentModal/index.tsx — CC 29, MI 59.45, SLOC 147
  • medium high-mdd — src/components/Global/ReConsentModal/index.tsx:39 — ReConsentModal: MDD 24.6 (uses across many lines from declarations)

✅ Resolved (2)

  • src/components/Global/ReConsentModal/index.tsx — CC 29, MI 59.59, SLOC 145
  • src/components/Global/ReConsentModal/index.tsx:39 — ReConsentModal: MDD 24.5 (uses across many lines from declarations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants