hotfix(re-consent): copy that answers the question users are actually asking - #2595
Conversation
ActionModal's sm:flex-1 (built for side-by-side CTAs) squashed the stacked h-13 buttons; 'Not now' inherited .btn's font-bold and competed with the primary; the checkbox label wrapped to two lines on mobile.
The modal told people something changed without saying what — for a
user with money in the app that reads as fees going up or data being
sold. The new copy answers that question first (fees, funds, data
handling: unchanged), says what the 2026-07-15 tos-v1 rewrite actually
did, and makes deferring look as fine as it actually is ("Not now"
snoozes to the effective date).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe re-consent modal now provides specific document-update context, confirms unchanged fees, funds, and data handling, updates the acceptance checkbox text, and adjusts stacked CTA styling. ChangesRe-consent modal updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated text to be non obvious ai write Signed-off-by: ab <78670703+abalinda@users.noreply.github.com>
Code-analysis diffPainscore total: 6349.78 → 6350.22 (+0.44) 🆕 New findings (2)
✅ Resolved (2)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/components/Global/ReConsentModal/index.tsx (1)
170-170: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a regression assertion for the acceptance wording.
The existing tests toggle
consent-checkboxbut do not render or assertcheckbox.text. Updatesrc/components/Global/ReConsentModal/__tests__/index.test.tsxto cover “I accept the updated documents”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Global/ReConsentModal/index.tsx` at line 170, Add a regression assertion in the ReConsentModal tests for the checkbox text “I accept the updated documents”. Render or query the consent checkbox’s text in the existing test setup and assert the expected wording, while preserving the current consent-checkbox toggle coverage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/Global/ReConsentModal/index.tsx`:
- Line 137: Update the title prop in ReConsentModal to “A small update to our
legal documents” so it accurately covers both privacy and terms documents
represented by outdatedDocs.
- Around line 150-152: Update the copy in ReConsentModal to split the final
comma-spliced sentence into separate sentences, preserving the existing meaning
and all other wording.
---
Nitpick comments:
In `@src/components/Global/ReConsentModal/index.tsx`:
- Line 170: Add a regression assertion in the ReConsentModal tests for the
checkbox text “I accept the updated documents”. Render or query the consent
checkbox’s text in the existing test setup and assert the expected wording,
while preserving the current consent-checkbox toggle coverage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c2d0f170-4bb7-4bfa-a30f-9fdf43434bd8
📒 Files selected for processing (1)
src/components/Global/ReConsentModal/index.tsx
| onClose={handlePostpone} | ||
| icon="info" | ||
| title="We've updated our terms" | ||
| title="A small update to our terms" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use a title that covers every displayed document.
outdatedDocs can include privacy as well as terms. The adjacent test renders both documents. If only the privacy document is outdated, “A small update to our terms” is misleading. Use “A small update to our legal documents”.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/Global/ReConsentModal/index.tsx` at line 137, Update the title
prop in ReConsentModal to “A small update to our legal documents” so it
accurately covers both privacy and terms documents represented by outdatedDocs.
| We've rewritten the documents below in plain language so they match what Peanut is today, | ||
| including the Peanut Card and Rewards. There's no rush, read them whenever, and keep using | ||
| Peanut as usual. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Split the final sentence.
The text contains a comma splice. Use separate sentences.
Suggested copy
- including the Peanut Card and Rewards. There's no rush, read them whenever, and keep using
+ including the Peanut Card and Rewards. There's no rush. Read them when you're ready, and keep using📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| We've rewritten the documents below in plain language so they match what Peanut is today, | |
| including the Peanut Card and Rewards. There's no rush, read them whenever, and keep using | |
| Peanut as usual. | |
| We've rewritten the documents below in plain language so they match what Peanut is today, | |
| including the Peanut Card and Rewards. There's no rush. Read them when you're ready, and keep using | |
| Peanut as usual. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/Global/ReConsentModal/index.tsx` around lines 150 - 152,
Update the copy in ReConsentModal to split the final comma-spliced sentence into
separate sentences, preserving the existing meaning and all other wording.
3 participants
Per Konrad's Slack note on the terms popup: the modal announced a change without saying what changed, which for someone with money in the app reads as "are the fees going up / is my data being sold". This replaces the copy so the first sentence answers that question.
Before
After
Every claim is checked against what actually happened:
inbox/tos-v1/drafts/RULINGS.md): no fee change (there are none to change), custody model untouched, and the privacy rewrite describes existing practices accurately (real processor list) rather than changing them.A code comment marks the what-changed line as specific to the 2026-07-15 rewrite, so the next document version bump revisits it instead of shipping stale reassurance.
Hotfix, targets
maindirectly (retargeted per Konrad — the modal only exists onmain). The branch is based on #2589, so this PR carries @jjramirezn's visual-polish commit plus the copy commit; whichever of the two merges first, the other's diff shrinks accordingly. CTA labels are unchanged, so the 16 modal tests still pass.🤖 Generated with Claude Code
Summary by CodeRabbit