Import anarci lazily so kasearch can be imported without it#4
Open
danieldanciu wants to merge 1 commit into
Open
Import anarci lazily so kasearch can be imported without it#4danieldanciu wants to merge 1 commit into
danieldanciu wants to merge 1 commit into
Conversation
anarci depends on the CC-licensed IMGT germline database, which makes it unsuitable for commercial use. Move the top-level `from anarci import anarci` into _number_chunk (the only place it is used) so `import kasearch` succeeds without anarci installed; it is only required if KA-Search's own ANARCI numbering path is actually called. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anarci depends on the CC-licensed IMGT germline database, which makes it unsuitable for commercial use. Move the top-level
from anarci import anarciinto _number_chunk (the only place it is used) soimport kasearchsucceeds without anarci installed; it is only required if KA-Search's own ANARCI numbering path is actually called. We are using immunum instead of anarci, which has a more permissive licence - if interested, I can create a pull request to replace anarci with immunum or add it as an alternative.