Repository navigation
Default inner_max_depth to None (#68) - #88
Merged
Merged
Conversation
…r tree size The old default inner_max_depth=3 capped inner trees at 8 leaves, so the default inner_max_leaf_nodes=8 never had an effect. Behaviour change: fitted trees change for users relying on the defaults. Fixes #68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default
inner_max_depthfrom 3 toNoneinSGTClassifier,SGTRegressorand the random SG forests, soinner_max_leaf_nodes=8controls inner tree size (best-first growth). Docstrings explain how the two limits interact. Addstests/test_inner_defaults.pyshowing that a default inner tree reaches depth 7 with 8 bins.Behaviour change: fitted trees change for anyone using the defaults.
Fixes #68