Repository navigation
Re-execute tutorials after inner_max_depth default change (#68) - #89
Merged
Merged
Conversation
The new default lets inner trees grow to 8 bins, so most printed accuracies and importances move. Update the TAO prose (test accuracy is now flat after refinement; the lambda_ sweep peaks at 0.03) and describe the new inner-tree defaults in the shape-functions knobs list. Refs #68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-runs all tutorial notebooks after #88 changed the
inner_max_depthdefault toNone. Printed accuracies and importances move in most notebooks.Prose updates:
tao.ipynb: the before/after TAO paragraph and thelambda_sweep paragraph now match the outputs (test accuracy is flat after TAO; the sweep peaks atlambda_=0.03). Both paragraphs already quoted stale numbers before this change.shape-functions.ipynb: the knobs list gives the new defaults and explains howinner_max_depthandinner_max_leaf_nodesinteract.Refs #68