Repository navigation
Retain self-match evidence for vaccine window selection - #456
Merged
Merged
Conversation
This was referenced Oct 2, 2026
iskandr
marked this pull request as ready for review
October 2, 2026 16:51
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self matching previously exposed one nearest sequence and its first origin, which is insufficient for choosing vaccine windows. Add
match_self_peptides/SelfProteome.match_candidatesandself_matches_in_windowsto retain every match within an explicit same-length Hamming radius, or every exact window occurrence, with all reference origins and caller-resolved exclusions.Keep supplied presentation observations, confirmed/inferred allele attribution, model records and same-allele coverage distinct. Search completeness and missing-result reasons survive typed CSV/TSV with evidence hashes. Shared CTA/non-CTA sequences retain both origins; oncoref continues to own membership. No match means only no match within the stated search coverage, and presentation does not establish TCR recognition. No predictor, TCR score or new selection recipe is introduced.
The released Vaxrank 3.36.0 consumer fixture loads its actual
builtin:openvax-v1bundle. Self evidence changes the selected window while preserving both intended epitopes, both alleles and all target score. A composed Topiary workflow joins evidence to measurements and verifies explicit unknown handling and exact audit replay. Update the consumer pin and stale baseline/self-evidence documentation; bump Topiary to 5.92.0.Validation: lint passes; 44 focused and actual Vaxrank consumer tests pass without warnings. The full one-worker
./test.shgate passes: 5,048 tests, zero skips and no unexpected warnings. PR and master CI are green. Released to PyPI as 5.92.0; wheel/source hashes verified and tagv5.92.0points to the merged commit. The clean-master release gate also passed all 5,048 tests.Fixes #455. Fixes #458. Fixes #459. Refs #412 and #224. Follow-up evidence coverage: #457; shared cleavage contract: #288. Broader binding-ranked axes, indel enumeration and automatic evidence acquisition remain in those issues. Primary scientific source: https://www.nature.com/articles/s41541-023-00713-y .