Repository navigation
Ship the full test suite in the sdist, tag releases; bump to 1.3.1 - #23
Merged
Merged
Conversation
- Add MANIFEST.in so the sdist includes tests/__init__.py and tests/common.py; setuptools only adds tests/test*.py by default, so tests run from the tarball failed on `from .common import eq_` (#9). A new `sdist` CI job runs the tests from the unpacked sdist. - deploy.sh, adapted from varcode's: deploys only from a clean master that matches live origin, refuses an existing tag, keeps each attempt's artifacts, runs `twine check --strict`, supports --dry-run, and tags v<version> and pushes the tag after upload (#7). - Drop the setup.py shim (raise the setuptools floor to 64 for pyproject-only editable installs) and the unused coveralls dev dependency; CI uploads coverage with the GitHub Action (#15). Claude-Session: https://claude.ai/code/session_01JyZ1WTFWJ3EZ41QdYzKwGP
Contributor
Coverage Report for CI Build 37643093271Coverage remained the same at 91.322%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9. Fixes #7, along with backfilled
v*tags for the past releases, which I'm pushing separately. Part of #15.tests/test*.pyby default, so the tarball was missingtests/__init__.pyandtests/common.py, and its tests failed onfrom .common import eq_. AMANIFEST.innow graftstests/.sdistCI job runs the tests from the unpacked tarball, so this can't come back unnoticed.deploy.shtags releases ([request] version tags #7). It's adapted from varcode's script.masterthat matches the liveorigin, and refuses if thev<version>tag already exists.dist/v<version>.*and runstwine check --strict.v<version>and pushes only that tag.--dry-runstops before the upload, and an optional version argument must matchversion.py.origin, and checked the guards: wrong branch, HEAD ahead of origin, existing tag, version mismatch.pip install --upgrade build twineon every deploy. Both are in thedevextras.setup.pystub. The setuptools floor goes up to 64, which pyproject-only editable installs need; I checkedpip install -e .in a fresh venv.coverallsdev dependency, since CI uploads coverage with the GitHub Action.typechecksstays for now, because varcode, mhctools and topiary import it without declaring it.https://claude.ai/code/session_01JyZ1WTFWJ3EZ41QdYzKwGP