You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several packaging leftovers remain after the move to pyproject.toml.
typechecks>=0.0.2 (pyproject.toml:28) is never imported.git log -S typechecks -- serializable/ tests/ finds no import in any commit. Every install pulls it in for nothing.
simplejson>=3.0.0 (pyproject.toml:29) is still imported at serializable/helpers.py:20. PR remove usage of external simplejson #10 replaces it with the stdlib json, but GitHub marks that PR as conflicting: it edits requirements.txt and setup.py's install_requires, and neither exists anymore. The stdlib module works as a drop-in here because to_json/from_json only pass dicts, lists, and primitives to dumps. With serializable.helpers.json patched to stdlib json, all 42 tests pass. The fix is to rebase remove usage of external simplejson #10 onto pyproject.toml or redo it.
coveralls in the dev extras (pyproject.toml:37) is unused. The workflow uploads coverage with coverallsapp/github-action (.github/workflows/tests.yml:64), and nothing runs the coveralls CLI.
setup.py only calls setup(), and its comment says metadata lives in pyproject.toml. Deleting it requires raising build-system.requires from setuptools>=61.0 to >=64 so pip install -e (used by develop.sh and CI) still works without it.
Proposed fix: drop typechecks and coveralls, land the simplejson removal, and delete setup.py along with the setuptools bump.
Still open: typechecks. serializable never imports it, but varcode, mhctools and topiary import it without declaring it, so it stays until they stop using it.
Topiary no longer blocks this cleanup: openvax/topiary#533 closed openvax/topiary#488 and shipped in Topiary 5.100.3. Its published runtime no longer imports typechecks; check_padding_around_mutation now performs the equivalent public-boundary validation directly and rejects falsy non-integers that previously bypassed the check.
The Varcode and MHCtools replacement issues (openvax/varcode#580 and openvax/mhctools#535) are also closed. I am leaving this issue open because openvax/varlens#34 remains open; before removing typechecks here, the minimum supported released dependency set should be verified end-to-end so a fresh install cannot lose the transitive module while a downstream package still imports it.
Activity
Use the stdlib json module instead of simplejson; bump to 1.3.0
Use the stdlib json module instead of simplejson; bump to 1.3.0
Use the stdlib json module instead of simplejson; bump to 1.3.0
Use the stdlib json module instead of simplejson; bump to 1.3.0
Use the stdlib json module instead of simplejson; bump to 1.3.0
Use the stdlib json module instead of simplejson; bump to 1.3.0 (#22)
Ship the full test suite in the sdist, tag releases; bump to 1.3.1 (#23)
iskandr commentedon Oct 7, 2026
Progress:
simplejson: removed in Use the stdlib json module instead of simplejson; bump to 1.3.0 #22 (1.3.0); PR remove usage of external simplejson #10 is superseded.coverallsdev dependency and thesetup.pystub: removed in Ship the full test suite in the sdist, tag releases; bump to 1.3.1 #23 (1.3.1).typechecks. serializable never imports it, but varcode, mhctools and topiary import it without declaring it, so it stays until they stop using it.iskandr commentedon Oct 7, 2026
Issues filed to replace
typecheckswithisinstancechecks and type annotations: openvax/varcode#580, openvax/mhctools#535, openvax/topiary#488, openvax/pyensembl#456 and openvax/varlens#34. The retirement plan is tracked in openvax/typechecks#5. serializable can drop the dependency once varcode, mhctools and topiary have released versions that no longer import it.iskandr commentedon Oct 28, 2026
Topiary no longer blocks this cleanup: openvax/topiary#533 closed openvax/topiary#488 and shipped in Topiary 5.100.3. Its published runtime no longer imports
typechecks;check_padding_around_mutationnow performs the equivalent public-boundary validation directly and rejects falsy non-integers that previously bypassed the check.The Varcode and MHCtools replacement issues (openvax/varcode#580 and openvax/mhctools#535) are also closed. I am leaving this issue open because openvax/varlens#34 remains open; before removing
typecheckshere, the minimum supported released dependency set should be verified end-to-end so a fresh install cannot lose the transitive module while a downstream package still imports it.