NE-2561: Add Gateway API OLM to NO-OLM migration upgrade test#30897
NE-2561: Add Gateway API OLM to NO-OLM migration upgrade test#30897gcs278 wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@gcs278: This pull request references NE-2292 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a Gateway API upgrade e2e test and registers it in the upgrade suite; the test provisions GatewayClass/Gateway/HTTPRoute, validates provisioning and connectivity before and after upgrades (detects OLM↔NO-OLM migration). Refactors controller helpers for Istio/OSSM checks and replaces echo backend Pod with a Deployment. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
|
/test e2e-gcp-ovn-upgrade |
|
/test ? |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
from
90dbe8d to
ac9d301
Compare
openshift-ci
bot
removed
the
approved
|
/test e2e-gcp-ovn-upgrade |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
2 times, most recently
from
b08e876 to
4df0775
Compare
|
/test e2e-gcp-ovn-upgrade |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 4df0775
New tests seen in this PR at sha: 4df0775
|
|
/test ? |
|
/payload list |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60c65dd0-22f9-11f1-91b0-a3e2ef55f2e7-0 |
|
Ah darn this isn't going to work because |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0 |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
from
4df0775 to
5b67673
Compare
|
[trying again] Okay, this is a bit crazy, but I created a draft promotion PR (openshift/api#2772) so that we can test with NoOLM as default since we don't have /payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade openshift/api#2772 openshift/cluster-ingress-operator#1354 Additionally, this should still run for OLM to OLM, or noOLM to noOLM (it's a generic z stream upgrade test): This would be noOLM to noOLM: So there's our 3 cases:
|
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0 |
|
@gcs278: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0 |
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
from
5b67673 to
3a16cc6
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 9aea19b
|
|
/verified by @rhamini3 |
openshift-ci-robot
added
the
verified
|
@rhamini3: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 9aea19b
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 9aea19b
|
|
@CodeRabbit now that the feature gate has been promoted (openshift/api#2772), can you give me new set of payload-job commands to re-run the upgrade tests? We cannot do OLM to OLM anymore since noOLM has been promoted, so you won't be able to give me those. My test matrix was here: #30897 (comment) |
|
Tip For best results, initiate chat on the files or code changes.
GCP Tests# Z-stream: NO-OLM → NO-OLM (presubmit, noOLM is now default)
/test e2e-gcp-ovn-upgrade
# Minor upgrade: OLM → NO-OLM (migration) — no api#2772 needed anymore
/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgradeAWS Tests# EUS upgrade: OLM → NO-OLM (migration)
/payload-job periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade-pausedvSphere Tests# Minor upgrade: OLM → NO-OLM (migration)
/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-vsphere-ovn-upgradeBareMetal Tests# Minor upgrade: OLM → NO-OLM (migration) — also a needed re-run since last run never provisioned the cluster
/payload-job periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.21-e2e-metal-ipi-ovn-upgradeUpdated matrix (OLM→OLM column dropped):
|
|
@coderabbitai[bot]: user coderabbitai[bot] is not trusted for pull request #30897 |
|
Just a sanity check now that the API promotion has merged: |
|
@gcs278: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c636fe00-33a1-11f1-8769-408dc68b4042-0 |
|
And noOLM to noOLM |
|
/lgtm |
|
@gcs278: This pull request references NE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9aea19b
New tests seen in this PR at sha: 9aea19b
|
Add upgrade test validating Gateway API migration from OLM-based Istio to CIO-managed Sail Library during 4.21 to 4.22 upgrades. Setup creates Gateway/HTTPRoute with OLM provisioning and tests connectivity. Test validates migration: Gateway remains programmed, Istiod running, Istio CRDs stay OLM-managed, GatewayClass has CIO finalizer, Istio CR deleted, subscription persists. Teardown cleans up all resources.
gcs278
force-pushed
the
gwapi-olm-upgrade-test
branch
from
9aea19b to
cf1f826
Compare
openshift-ci-robot
removed
the
verified
|
New changes are detected. LGTM label has been removed. |
|
Ah one more fix - so until openshift/api#2772 merged, I now realize had never tested the noOLM to noOLM path. I was previously thinking my workaround Now that 2772 merged, e2e-gcp-ovn-upgrade is actually testing noOLM to noOLM, which exposed a latent bug which assumed the |
|
And for good measure, I'll kick off the y-stream and EUS payload tests again: /payload-job periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade-paused periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-vsphere-ovn-upgrade periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.21-e2e-metal-ipi-ovn-upgrade |
|
@gcs278: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9084ef70-33be-11f1-917f-5e72a16910fe-0 |
|
Scheduling required tests: Scheduling tests matching the |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: cf1f826
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, petr-muller, rhamini3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: cf1f826
|
5 participants
Add upgrade test validating Gateway API migration from OLM-based Istio to CIO-managed Sail Library during 4.21 to 4.22 upgrades.
Setup creates Gateway/HTTPRoute with OLM provisioning and tests connectivity. Test validates migration: Gateway remains programmed, Istiod running, Istio CRDs stay OLM-managed, GatewayClass has CIO finalizer, Istio CR deleted, subscription persists. Teardown cleans up all resources.
Note: While this isn't strictly blocked on noOLM GA promotion (openshift/api#2772), if it merges before it, it will only test OLM --> OLM, and noOLM --> noOLM as TechPreview cannot be upgraded (upgrade CI jobs don't exist for TP).
Commands to Run Complete Test Set
GCP Tests
AWS Tests
# EUS upgrade: OLM → NO-OLM /payload-job periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade-pausedvSphere Tests
# Minor upgrade: OLM → NO-OLM /payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-vsphere-ovn-upgradeBareMetal Tests
# Minor upgrade: OLM → NO-OLM /payload-job periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.21-e2e-metal-ipi-ovn-upgradeCC: @rhamini3