NE-2520: Promote GatewayAPIWithoutOLM to GA#2772
NE-2520: Promote GatewayAPIWithoutOLM to GA#2772openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Hello @gcs278! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e01ef8c0-2309-11f1-813c-239011e41911-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0198a9d0-233f-11f1-9a7d-ebebc862b301-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07dadcd0-2391-11f1-8c59-fe2512e5aad1-0 |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ab81910-23c6-11f1-8635-bf728c1f5aad-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e4a3720-2406-11f1-93e5-9f16732fd0e5-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ddd5ec0-2493-11f1-8cf8-effe9a495bea-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/69a77f80-24c8-11f1-9403-ad1a7c99fb97-0 |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a761690-24c8-11f1-9c74-da2cb51d6692-0 |
|
@gcs278: This pull request references NE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This pull request references NE-2520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gcs278: This PR was included in a payload test run from openshift/origin#30897
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d5568f0-2710-11f1-9d03-561b26d4f2f7-0 |
70d9187 to
64340c4
Compare
Looks like the linked PR only removes support for dual stack, not IPv6 - just to make sure, we are certain we do not support ipv6 networking for this feature? |
My general stance is that if we have (or should have) signal for a platform, we shouldn't be promoting until the criteria are met. If the promotion is urgent, the OpenShift architects and the BU are the ones that need to make the decision on whether or not a promotion goes through without sufficient testing via an SBAR. In this case, I'd say lets just collect the runs. If you need extra runs you can use the gangway cli (https://github.com/openshift-eng/gangway-cli) to trigger more job runs. |
Yes, I'm certain. Though we do claim support for Metal/VSphere (NE-2010), we do not claim support for IPv6 and DualStack for the entire Gateway API feature. We don't run tests on it today, and when I tried to enable it for IPv6, Gateway API doesn't work. And my feature (
Agreed, I added them last week in openshift/origin#30946 (I forgot to link here). We are getting signal now, but it looks like we are at 87% for Vsphere for this specific test (2/16 flaked): The 2 flakes are due to the test hardness code for I have a fix up here for it openshift/origin#30964. @JoelSpeed @everettraven would you consider allowing us to promote? I did the math, and we'd need 24 more tests to succeed in a row to get back to 95%. I don't think we have quite that runway at the moment. I could gangway the Vsphere tests, but it'd seem a bit hard on our VSphere resources (i'd need to run 6-7 times a day to get in by branch cut). I'm confident the VSphere feature functionality is working as expected. To summarize the
Please let me know if you'd need anything from me. |
|
/pipeline required |
|
Scheduling tests matching the |
|
/test verify-feature-promotion |
|
PR-Agent: could not fine a component named |
Thanks for the additional context.
My stance would be:
|
|
@everettraven Thanks - I understand the caution here given the timeline. Getting to 95% likely isn't going to work given our desired timeline of making branch cut (and we'd like to merge in the next day or so). So we will need to get folks to sign off. To help illustrate my confidence:
CC: @JoelSpeed |
|
Given the above, and that the only failures visible in sippy are from test cleanup which we are now confident is fixed /override ci/prow/verify-feature-promotion /lgtm /retest |
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed I think you'll need to re-apply the override. |
|
/override ci/prow/verify-feature-promotion HyperShift conformance has a known image configuration issue |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-azure Failures appear to me to be unrelated |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/verify-feature-promotion |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR promotes the
GatewayAPIWithoutOLMfeature gate from TechPreviewNoUpgrade to Default (GA).Background
The
GatewayAPIWithoutOLMfeature replaces the OLM-based Istio installation method with direct Helm chart installation via the Sail library, enabling Gateway API support on clusters without OLM/Marketplace capabilities and avoiding conflicts with existing OSSM subscriptions.Related Work
Testing