Skip to content

Update test #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 6, 2026
+15 −16
Merged

Update test #2096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tekton/integration-tests/lightspeed-console-pre-commit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ spec:
env:
- name: COMMIT_SHA
value: $(params.commit)
image: mcr.microsoft.com/playwright:v1.60.0-noble
image: mcr.microsoft.com/playwright:v1.61.1-noble
resources:
limits:
memory: 4Gi
Expand Down Expand Up @@ -236,7 +236,7 @@ spec:
resources:
limits:
memory: 8Gi
image: mcr.microsoft.com/playwright:v1.60.0-noble
image: mcr.microsoft.com/playwright:v1.61.1-noble
script: |
echo "COMMIT_SHA: ${COMMIT_SHA}"
echo "BASE_URL: ${BASE_URL}"
Expand Down
25 changes: 12 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"webpack-cli": "^7.0.2"
},
"devDependencies": {
"@playwright/test": "1.60.0",
"@playwright/test": "1.61.0",

@coderabbitai coderabbitai Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "package.json:"
sed -n '54,62p' package.json

echo
echo ".tekton/integration-tests/lightspeed-console-pre-commit.yaml:"
sed -n '260,290p' .tekton/integration-tests/lightspeed-console-pre-commit.yaml

Repository: openshift/lightspeed-console

Length of output: 2054

🌐 Web query:

Playwright Docker image version must match @playwright/test version official docs

💡 Result:

Yes, official Playwright documentation explicitly states that you should use a Docker image version that matches the version of your project's @playwright/test dependency [1][2][3]. When running tests in a Docker container, it is required that the Playwright version in your project matches the version running in the Docker image to ensure the system can correctly locate and execute the required browser binaries [1][2]. If these versions do not match, Playwright will be unable to locate the browser executables, which will cause your tests to fail [1][4][5]. To maintain consistency, Playwright recommends pinning your Docker image to a specific version that corresponds to the version used in your project [1][2][3]. You can select images with specific tags (e.g., v1.61.0-noble or v1.61.0-jammy) from the Microsoft Artifact Registry [1][2][5].

Citations:

Align the Playwright versions. package.json still pins @playwright/test to 1.61.0, but the Tekton image is v1.61.1-noble. Playwright expects the project package and Docker image to use the same version, or npx playwright test can fail to find the bundled browsers.

Suggested fix 
-    "`@playwright/test`": "1.61.0",
+    "`@playwright/test`": "1.61.1",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@playwright/test": "1.61.0",
"`@playwright/test`": "1.61.1",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 58, Align the Playwright dependency version in
package.json with the Tekton image version so they match exactly. Update the
`@playwright/test` pin from 1.61.0 to the same 1.61.1 release used by the Tekton
image, keeping the package and runtime image in sync to avoid browser resolution
issues when running npx playwright test.

"@types/lodash": "4.17.24",
"@types/node": "^22.19.17",
"@types/react": "^17.0.91",
Expand Down