Update test#2096
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Tekton pre-commit pipeline updates two Playwright container image tags, and ChangesPlaywright version refresh
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
99b25ee to
afaa4c4
Compare
afaa4c4 to
f94e87e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 58: Align the Playwright dependency version in package.json with the
Tekton image version so they match exactly. Update the `@playwright/test` pin from
1.61.0 to the same 1.61.1 release used by the Tekton image, keeping the package
and runtime image in sync to avoid browser resolution issues when running npx
playwright test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: eeba062f-408b-45c8-863a-e0fb0a29149c
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
.tekton/integration-tests/lightspeed-console-pre-commit.yamlpackage.json
🚧 Files skipped from review as they are similar to previous changes (1)
- .tekton/integration-tests/lightspeed-console-pre-commit.yaml
| }, | ||
| "devDependencies": { | ||
| "@playwright/test": "1.60.0", | ||
| "@playwright/test": "1.61.0", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "package.json:"
sed -n '54,62p' package.json
echo
echo ".tekton/integration-tests/lightspeed-console-pre-commit.yaml:"
sed -n '260,290p' .tekton/integration-tests/lightspeed-console-pre-commit.yamlRepository: openshift/lightspeed-console
Length of output: 2054
🌐 Web query:
Playwright Docker image version must match @playwright/test version official docs
💡 Result:
Yes, official Playwright documentation explicitly states that you should use a Docker image version that matches the version of your project's @playwright/test dependency [1][2][3]. When running tests in a Docker container, it is required that the Playwright version in your project matches the version running in the Docker image to ensure the system can correctly locate and execute the required browser binaries [1][2]. If these versions do not match, Playwright will be unable to locate the browser executables, which will cause your tests to fail [1][4][5]. To maintain consistency, Playwright recommends pinning your Docker image to a specific version that corresponds to the version used in your project [1][2][3]. You can select images with specific tags (e.g., v1.61.0-noble or v1.61.0-jammy) from the Microsoft Artifact Registry [1][2][5].
Citations:
- 1: https://playwright.dev/docs/docker
- 2: https://github.com/microsoft/playwright/blob/main/docs/src/docker.md
- 3: https://playwright.dev/python/docs/docker
- 4: https://hub.docker.com/r/microsoft/playwright
- 5: https://mcr.microsoft.com/en-us/product/playwright/about
Align the Playwright versions. package.json still pins @playwright/test to 1.61.0, but the Tekton image is v1.61.1-noble. Playwright expects the project package and Docker image to use the same version, or npx playwright test can fail to find the bundled browsers.
Suggested fix
- "`@playwright/test`": "1.61.0",
+ "`@playwright/test`": "1.61.1",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@playwright/test": "1.61.0", | |
| "`@playwright/test`": "1.61.1", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 58, Align the Playwright dependency version in
package.json with the Tekton image version so they match exactly. Update the
`@playwright/test` pin from 1.61.0 to the same 1.61.1 release used by the Tekton
image, keeping the package and runtime image in sync to avoid browser resolution
issues when running npx playwright test.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
f94e87e to
6921b30
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
1.60.0→1.61.01.61.1v1.60.0-noble→v1.61.1-nobleRelease Notes
microsoft/playwright (@playwright/test)
v1.61.0Compare Source
🔑 WebAuthn passkeys
New Credentials virtual authenticator, available via browserContext.credentials, lets tests register passkeys and answer
navigator.credentials.create()/navigator.credentials.get()ceremonies in the page — no real hardware key required, works in all browsers:You can also let the app register a passkey once in a setup test, read it back with credentials.get(), and seed it into later tests — see Credentials for details.
🗃️ Web Storage
New WebStorage API, available via page.localStorage and page.sessionStorage, reads and writes the page's storage for the current origin:
New APIs
Network
Browser and Screencast
artifactsDirin browserType.connectOverCDP() controls where artifacts such as traces and downloads are stored when attached to an existing browser.cursorin screencast.showActions() controls the cursor decoration rendered for pointer actions.onFramecallback in screencast.start() now receives atimestampof when the frame was presented by the browser.Test runner
trace: new'on-all-retries','retain-on-first-failure'and'retain-on-failure-and-retries'values. See the video modes table for which runs are recorded and kept in each mode.expect.soft.poll(...).process.argvfrom the runner process, handy for reading custom arguments passed after the--separator.AggregateErroras a separate entry.-Gcommand line shorthand for--grep-invert.🛠️ Other improvements
Browser Versions
This version was also tested against the following stable channels:
Configuration
📅 Schedule: (in timezone UTC)
* * * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.