Repository navigation
test(sdks/go): remove timeout-message race from connection diagnostic - #2479
Draft
yangjj-iso wants to merge 1 commit into
Draft
yangjj-iso wants to merge 1 commit into
yangjj-iso wants to merge 1 commit into
Conversation
8 of 10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDiag_ReusedConnBlackHoleReproducesClientTimeout. On unchanged main97031ea8, 4 of 30 local runs failed because the returned timeout lacked the literalClient.Timeout exceeded while awaiting headerssuffix.traceTransport. In Go 1.20,net/httpcan return the request-context deadline error before its separate client-timeout timer marks the error for that suffix. Both outcomes are timeouts; the exact wording is not the behavior being tested.net.Error.Timeout()instead, and explicitly verify that the second request reused the black-holed connection. Keep the real HTTP server, client timeout, and all test execution; do not skip or shorten the diagnostic. Production code is unchanged.Testing
-count=30failed 4 times on the original string assertion.-count=30passed (27.059s).go test ./... -count=1passed (11.840s), with no skipped diagnostic.go test -race ./... -count=1passed (13.050s);go vet ./...andgit diff --checkpassed.Breaking Changes
Checklist
Related failure reports appeared in #2452 and #2468. This PR fixes that independent test-reliability problem, not those SDK defects.