Repository navigation
fix(sdks/go): require confirmed success for interpreter readiness probes - #2480
Draft
yangjj-iso wants to merge 1 commit into
Draft
yangjj-iso wants to merge 1 commit into
yangjj-iso wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeInterpreter.IsHealthyandwaitRuntimeReadyresults when the runtime-check SSE response ends after onlyinitorstdout. These executions have no error event, but also no confirmed completion; the existing checks incorrectly treated them as healthy/ready.RunCommandalready infers exit code 0 from a successfulexecution_completeevent that omitsexit_code.Testing
go test ./... -count=1passed (12.272s).go test -race ./... -count=1passed (13.425s);go vet ./...andgit diff --checkpassed.Breaking Changes
Checklist