Repository navigation
feat(fusion): bound first-worker turns before edit handoff - #1031
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds an optional first-worker turn cap to edit-handoff benchmarks and keeps differently capped runs separate during analysis. Example: An edit-handoff benchmark has four shared calls and FUSION_HANDOFF_MAX_TURNS=2; the first worker only reads files.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds a useful benchmark allocation control absent from main; no actionable patch defects were found. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe offline Fusion benchmark runner sends qualified repository tasks through sandboxed repair agents, records model calls and acceptance results, and passes saved reports to the paired analyzer. flowchart LR
A[Qualified repair task] --> B[Pair benchmark runner]
B --> C[First worker]
C --> D[Existing handoff boundary]
D --> E[Successor worker]
E --> F[Independent acceptance]
F --> G[Saved pair report]
G --> H[Pair analyzer]
Technical reviewBest possible solution: Keep the cap opt-in within the existing handoff owner, preserving shared limits, fixed controls and legacy report compatibility. Do we have a high-confidence way to reproduce the issue? Main's edit-handoff loop waits for a passing edit or submission, so repeated reads can exhaust every turn without a successor call; this follows directly from the source and existing no-edit test. Is this the best way to solve the issue? The patch is a focused extension of the existing boundary, with matching control propagation and protocol separation; the maintainer-authored proposal establishes direction. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 1e4104fb47f7. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 8:35 AM ET / 13:35 UTC. |
Summary
Add an opt-in first-worker turn cap to edit handoff benchmarks. If the first worker has not produced a passing edit by the cap, the successor receives the remaining shared allowance. Existing defaults and fixed controls stay unchanged.
Record the cap in pair receipts and reject pooling runs with different caps. Matched handoff controls use the same boundary. This establishes bounded allocation; it does not claim a measured quality or cost gain.
Verification
Deployment and risk
No deployment or default promotion. The setting can change model allocation, so compare against fixed-model controls before using it for a benchmark claim.