Repository navigation
feat(fusion): gate handoff on a discriminating repair probe - #1043
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
c05ef8b to
dd4c29a
Compare
|
Codex review: needs maintainer review before merge. What this changesAdd an optional Fusion handoff gate requiring an original-failing, candidate-passing assertion probe before normal worker transfer. Example: An edit-handoff run enables both probe gates, makes a visible-test-passing edit, and runs console.log(1).
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds a distinct optional benchmark capability absent from current main, and no actionable patch defect was found. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherFusion benchmark scripts coordinate model workers in isolated repair sandboxes, consume task definitions and qualification receipts, and produce independently graded results and accounting reports. flowchart TD
A[Task and qualification] --> B[Pair benchmark]
B --> C[First repair worker]
C --> D[Original and candidate probe comparison]
D --> E[Successor worker]
E --> F[Independent grading and reports]
Technical reviewBest possible solution: Land the optional gate using the existing comparison and regression owners while retaining independent acceptance and unchanged defaults. Do we have a high-confidence way to reproduce the issue? This is a feature request embodied in a patch; source inspection confirms the existing passing-edit handoff boundary, and no target code was executed. Is this the best way to solve the issue? The implementation is appropriately scoped: it reuses isolated candidate comparison and pinned regression replay instead of adding another execution path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 43d978e80dfa. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 1:33 PM ET / 18:33 UTC. |
Summary
An edit-handoff currently transfers to the cheaper worker as soon as an edit passes the original visible tests, which may already pass on broken source. Add an opt-in gate requiring the same bounded probe to fail with an assertion on frozen original source and pass on the current candidate in fresh isolated sandboxes. Recheck current visible and pinned regression tests before normal transfer.
Expose
FUSION_HANDOFF_PROBE_GATE=1for regression-gated edit/matched-handoff runs. Explicit turn limits still transfer unfinished work. Keep defaults, hidden acceptance and shared call/cost/time limits unchanged. Record the gate in receipts and reject mixed repeated protocols.Verification
ERR_ASSERTION.Deployment and risk
No deployment, release or default activation. Extra isolated checks consume the existing deadline and can reduce useful work. One discriminating probe does not prove full task correctness. A bounded matched development experiment stopped on an upstream HTTP 400 token-limit response before the lifecycle arms completed. Completed streaming-task arms passed for both matched Sol and mixed execution, but the incomplete block establishes no aggregate efficacy gain. The runner retained its uncertain charge and made no later calls or retry. No efficacy claim is part of this PR.