fix(ci): prepare Luna high scanner settings - #3800
vincentkoc wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
|
Codex review: blocked before merge. Reviewed October 4, 2026, 1:50 PM ET / 17:50 UTC (Revision 9). ClawSweeper reviewWhat this changesThe branch selects GPT-6 Luna with high reasoning in both scanner-worker workflows, updates configuration assertions, and documents the pending rollout. Merge readiness⛔ Blocked before merge - 4 items remain Keep open: Luna/high activation remains distinct from the merged preparation and is not implemented on current main. The previously reported scanner-version blocker remains unchanged; the upstream A.I.G change has now merged. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s security workers scan uploaded skills and packages using ClawScan and supporting scanners. Their results feed publication checks and moderation decisions. flowchart LR
A[Uploaded skills and packages] --> B[Security worker workflows]
B --> C[Pinned scanner releases]
C --> D[Supporting scanner evidence]
D --> E[ClawScan judge]
E --> F[Publication and moderation results]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Activate one consistent scanner policy using compatible released dependencies and verified worker credentials, while preserving current defaults until rollout is ready. Do we have a high-confidence way to reproduce the issue? Yes, for the configuration defect: both workers select the installed clawhub profile, whose immutable v0.1.8 source explicitly fixes the judge model to gpt-5.5. No credentialed runtime failure was reproduced. Is this the best way to solve the issue? No, the environment-only activation is incomplete. Coordinated dependency adoption is the best fix; a copied judge launcher would duplicate the authoritative ClawScan profile, while optional environment forwarding already landed separately. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 0180b561dfef. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (8 earlier review cycles)
|
|
@Patrick-Erichsen we’re using Tencent/AI-Infra-Guard#676 for ClawHub’s Luna/high activation. Once it is merged and published, please share the |
6c2c975 to
3c2b00c
Compare
What Problem This Solves
The requested scanner policy is GPT-6 Luna with high reasoning for the ClawScan judge, SkillSpector, and A.I.G. Current released scanner dependencies do not yet implement that policy end to end.
User Impact
Draft — activation is incomplete and must not merge until the dependency and live-proof checklist below is complete. This draft sets explicit model and effort values in both worker workflows. Coverage, moderation decisions, credential isolation, and exact-artifact result reuse stay unchanged. Skill Card generation is outside this change.
The independently safe preparation has landed in #3802 at
9a614dc195afbe1b6834065c6521018b8100afde: optional controls now pass through both restricted worker environments, and the mobile metadata layout assertion uses a controlled local fixture. Deployed workflow defaults and scanner pins were preserved by that merge.Remaining Dependency Order
aig-skill-scanPyPI version supportingREASONING_EFFORT. The existing PR is the upstream route; do not publish a duplicate. At the latest check on September 24, 2026, PR 676 was open atde2c5db39855e7e619c8e2d6098ad30b599f7084, and the latest PyPI release was 0.2.2, which ignores this setting.490bd167ea431697ac42f566adb06281db53c720. The latest published ClawScan is still 0.2.0, whose immutable source uses the older judge profile; source landing alone does not update the package or runtime image..github/workflows/prepublication-publish-checks.ymland.github/workflows/security-scan-codex.yml; regeneratescripts/security/aig-worker-requirements.txtwith hashes; update the matching version assertions inscripts/security/prepublication-worker-workflow.test.tsandscripts/security/security-scan-worker-workflow.test.ts. Both workflows currently retain ClawScan 0.1.8 and A.I.G 0.2.2. Keep the existing SkillSpector commit unless a verified dependency requirement changes.The existing dependency notification is #3800 (comment). No package/image release or production scan dispatch has been performed by this PR.
Why This Change Was Made
The worker environment boundary is already repaired on main. This draft now changes only the two workflow settings, their corresponding assertions, and rollout documentation. The judge remains owned by ClawScan's embedded profiles; there is no launcher shim, copied scanner implementation, or invented dependency version.
Application production TypeScript: unchanged. Workflow configuration: net +6 lines. Tests: net +6 lines. Changelog/specs: +6 lines.
Evidence And Limits
Current draft head:
3c2b00c596ae47519ed38e7ed009d7732772d509, rebased onto the landed preparation. The four workflow/test files are byte-identical to the previously reviewed6c2c9757d5b532eb5f55ccd28ff016e791d1aff3; all worker and browser-fixture files match the landed preparation. The only conflict resolutions preserve the landed documentation and describe the requested policy as pending.git diff --checkpassed.69dcdfbwas tested against a loopback HTTP server with minimum-supportedlangchain-openai 1.1.10 / openai 2.54.0and currently resolved1.6.5 / 3.19.2: serializedPOST /v1/chat/completions,model=gpt-6-luna,reasoning_effort=high,response_format=json_schema; parsed output passed. No function tools,temperature,top_p,top_logprobs, orlogprobswere sent. No provider call was made.The original local A.I.G patch had separate historical tests; those results are not transferred to upstream PR 676, whose implementation differs. Use PR 676's final merged/released code for activation acceptance.
AI-assisted implementation; scoped changes and dependency contracts were inspected and validated as described above.