Repository navigation
fix(skill-scan): forward optional reasoning effort to the model API - #676
Merged
boy-hack merged 1 commit intoSep 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aig-skill-scancurrently ignoresREASONING_EFFORT, so callers cannot request a reasoning level from a compatible model. Read the optional setting and forward a nonblank value asreasoning_effortin the Chat Completions request. Trim surrounding whitespace and omit the parameter when unset or blank, preserving the existing request behavior.Document the setting in the English and Chinese READMEs. Supported values remain model/provider-dependent; this does not change model defaults or require an SDK upgrade.
Type of change
How was this tested?
1a5ffa3:REASONING_EFFORT=highproduced a request withoutreasoning_effort. It passes after the fix.cd skill-scan && .venv/bin/python -m pytest pytests -q: 84 passed, including configured, whitespace-trimmed, unset, empty, and whitespace-only settings.cd skill-scan && .venv/bin/ruff check skill_scan/utils/llm.py pytests/test_llm_request.py: passed.cd skill-scan && .venv/bin/python main.py --help: passed.go build ./...: passed.git diff --check: passed.Compared the base and candidate through the pinned
openai==2.8.1SDK using an HTTPX mock transport and a valid streamed response:REASONING_EFFORT=high"reasoning_effort": "high"Both versions parsed the streamed response successfully. No external provider calls were made; this validates request serialization, not account/model availability.
Related issue
N/A. Downstream integration: openclaw/clawhub#3800.
Checklist
go build ./...succeeds locally