fix(api): preserve plaintext and rich audio response types - #731
Conversation
Castiron custom codeMixed files: 70 → 76 6 newly customized · 0 customizations removed · 0 existing customizations changed · 2 generated baselines changed Compared
70 existing customizations unchanged
30 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35567449058 --repo openai/openai-ruby \
--name castiron-custom-code-35567449058-1 --dir /tmp/castiron-custom-code-35567449058-1
git apply --stat /tmp/castiron-custom-code-35567449058-1/custom-code.patch
cat /tmp/castiron-custom-code-35567449058-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 33435479c2d98603b93c810183d314bc55cd1ee7 1e3d8d041cd4910b250b7e66b313718f38821bd5
python3 scripts/castiron/custom_code_report.py report \
--base 33435479c2d98603b93c810183d314bc55cd1ee7 \
--head 1e3d8d041cd4910b250b7e66b313718f38821bd5 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-1e3d8d041cd4
cat /tmp/castiron-custom-code-1e3d8d041cd4/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Castiron-Internal-PR: openai/openai-ruby-internal#127 Castiron-Source-SHA: c1e514cd869d015b12d40a18d4d0e4524100f8a1 Castiron-Public-Base-SHA: 3343547
f12f0e1 to
1e3d8d0
Compare
Summary
Preserves complete audio payloads and selects rich response models using the effective request format.
Changes
StringIOalongside JSON models for text, SRT and VTT responses and updates the audio example accordingly.Related reports: transcription plaintext media, speech media types, and overlapping transcription response shapes.