revert: restore behavior before #731 - #736
Conversation
)" This reverts commit e28d537.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 70 mixed files remain; 0 existing customizations changed; 6 customizations removed; 2 generated baselines changed. Compared
70 existing customizations unchanged
30 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35622493412 --repo openai/openai-ruby \
--name castiron-custom-code-35622493412-1 --dir /tmp/castiron-custom-code-35622493412-1
git apply --stat /tmp/castiron-custom-code-35622493412-1/custom-code.patch
cat /tmp/castiron-custom-code-35622493412-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin e28d53742410c3d8b7a4b2f47b37bfa02e3b1a25 65352873fa7b366fbc87526791f73a5d4ceacd7e
python3 scripts/castiron/custom_code_report.py report \
--base e28d53742410c3d8b7a4b2f47b37bfa02e3b1a25 \
--head 65352873fa7b366fbc87526791f73a5d4ceacd7e --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-65352873fa7b
cat /tmp/castiron-custom-code-65352873fa7b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65352873fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Reverts #731 because the generated change merged before its source-of-truth changes.
This is the exact inverse of squash commit e28d537. The resulting tree matches its parent33435479c2d98603b93c810183d314bc55cd1ee7, restoring the prior audio behavior, declarations and matching generation metadata.
Local checks passed: lint, Sorbet, RBS, gem build, browser checks, offline Castiron checks, Bedrock tests and focused response/multipart/audio tests. Customization budget: 3,559/4,000. The full mock suite could not start because the pinned Steady JSR dependency was unreachable; current-head CI will provide the full-suite result.