Repository navigation
Clarify RPC response-status review policy - #20790
Merged
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-21 05:54 UTC Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update documentation to extend policy from PR #20740 to RPC
Clarify RPC response-status review policy
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes clearly express the intended policy with no unresolved issues.
No open issues 🎉
What changed in this PR
Clarifies telemetry review guidance by extending the failure-only response-status policy to RPC.
Changes:
- Discourages redundant status attributes when failure codes already populate
error.type. - Preserves existing success/failure status capture, error classification, and exception-type fallback.
| File | Description |
|---|---|
.github/instructions/emitted-telemetry.instructions.md |
Extends database guidance to RPC and clarifies instrumentation-level status retention. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16f77d1f-3c3c-479b-829c-d79f09cd1a96
trask
marked this pull request as ready for review
October 21, 2026 04:02
trask
approved these changes
Oct 21, 2026
laurit
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error.type.error.type. Keep status-based error classification and exception-type fallback unchanged.