Skip to content

Clarify RPC response-status review policy - #20790

Merged
laurit merged 3 commits into
mainfrom
copilot/extend-policy-to-rpc
Oct 21, 2026
Merged

laurit merged 3 commits into
mainfrom
copilot/extend-policy-to-rpc

Conversation

Copilot AI commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  • Policy: Extend the existing database guidance to RPC: don’t request a separate response-status attribute when status is captured only on failures and would duplicate error.type.
  • Capture behavior: Preserve status attributes for instrumentation that captures both successful and failed operations, including failures whose status matches error.type. Keep status-based error classification and exception-type fallback unchanged.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-21 05:54 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Update documentation to extend policy from PR #20740 to RPC Clarify RPC response-status review policy Oct 21, 2026
Copilot AI requested a review from trask October 21, 2026 03:49
@trask
trask requested a balanced review from Copilot October 21, 2026 03:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes clearly express the intended policy with no unresolved issues.

No open issues 🎉

What changed in this PR

Clarifies telemetry review guidance by extending the failure-only response-status policy to RPC.

Changes:

  • Discourages redundant status attributes when failure codes already populate error.type.
  • Preserves existing success/failure status capture, error classification, and exception-type fallback.
File Description
.github/​instructions/​emitted-telemetry.instructions.md Extends database guidance to RPC and clarifies instrumentation-level status retention.

Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 16f77d1f-3c3c-479b-829c-d79f09cd1a96
@trask
trask marked this pull request as ready for review October 21, 2026 04:02
@trask
trask requested a review from a team as a code owner October 21, 2026 04:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation change matches the stated intent and has no identified actionable issues.

No open issues 🎉

Review effort: Balanced

@laurit
laurit merged commit cdca19e into main Oct 21, 2026
70 checks passed
@laurit
laurit deleted the copilot/extend-policy-to-rpc branch October 21, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants