Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-20 18:53 UTC Move out of draft to request review. Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add classification for Dubbo RPC exception codes
Classify Dubbo RPC errors by exception code
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Review found no blocking issues in classification, fallback handling, preview gating, or telemetry integration.
No open issues 🎉
What changed in this PR
Adds structured Dubbo RPC error classification to preview telemetry while preserving legacy output.
Changes:
- Maps known exception codes
1–13toerror.type, including wrapped asynchronous failures. - Adds coverage for client/server errors, fallbacks, success, RPC modes, and preview duration metrics.
| File | Description |
|---|---|
| instrumentation/apache-dubbo-2.7/library-autoconfigure/src/test/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/TracingFilterTest.java | Tests error classification and emitted telemetry. |
| instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java | Classifies known Dubbo exception codes. |
Review effort: Balanced
trask
reviewed
Oct 20, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 20, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 20, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
changed the title
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Preserve role-specific Triple error classification alongside explicit RPC schema selection. Apply the incoming failure-only response-status policy to both roles, support internal attribute removal, and correct latest-version integration fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classifies Dubbo Triple failures by their preserved protocol status in RPC-preview telemetry instead of grouping them under
StatusRpcException.For example, a preserved client deadline failure produces:
Client and server spans and duration metrics omit the failure-only
rpc.response.status_codeattribute rather than duplicating protocol error codes.Uses the exception class when no Triple status is available, including native Dubbo failures. Applies role-specific client/server error rules without adding bytecode hooks; response statuses unavailable at the existing filter boundary are not inferred.