Repository navigation
Remove redundant logging preview-test coverage - #20579
Merged
Merged
Conversation
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Clean up logging preview-test by removing duplicates
Remove redundant logging preview-test coverage
Oct 13, 2026
Pull request dashboard statusMerged · refreshed 2026-10-13 18:40 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The removed configuration is redundant with defaults, and the relevant regression tasks remain wired into verification.
0 open findings
What changed in this PR
Removes redundant v3-preview test configuration while retaining targeted logging regression coverage.
Changes:
- Removes Log4j’s duplicate preview test task.
- Runs the root-context regression under the default configuration.
- Removes Logback’s redundant explicit default override.
| File | Description |
|---|---|
instrumentation/logback/logback-appender-1.0/javaagent/build.gradle.kts |
Simplifies structured-attribute exclusion tasks. |
instrumentation/log4j/log4j-appender-2.17/library/src/test/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/OpenTelemetryAppenderTest.java |
Removes an unnecessary default-mode annotation. |
instrumentation/log4j/log4j-appender-2.17/javaagent/build.gradle.kts |
Removes duplicate preview task and wiring. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
trask
approved these changes
Oct 13, 2026
laurit
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate common-preview test configuration from the logging appenders while preserving their supported regression coverage.