Repository navigation
Expose resolution diagnostics when Muzzle assertPass fails - #20581
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Pull request dashboard statusMerged · refreshed 2026-10-14 06:05 UTC Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Expose collected resolution exceptions for assertPass failures
Expose resolution diagnostics when Muzzle assertPass fails
Oct 13, 2026
trask
reviewed
Oct 13, 2026
Contributor
Author
There was a problem hiding this comment.
Removed in 2c9b1d8, along with the now-unused TestKit dependency. Remaining plugin tests pass.
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
approved these changes
Oct 13, 2026
laurit
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed Muzzle
assertPasschecks currently hide exceptions collected during lenient dependency resolution. This change exposes those exceptions and their causes without changing compatibility decisions.assertPassvalidation throws, then rethrow the original Muzzle exception. Successful checks andassertFailchecks remain unchanged.Resolution failures are diagnostic evidence, not proof of what caused a Muzzle mismatch.