Skip to content

Fix/1073#1074

Merged
aaronchongth merged 13 commits intomainfrom
fix/1073
Feb 23, 2026
Merged

Fix/1073#1074
aaronchongth merged 13 commits intomainfrom
fix/1073

Conversation

@aaronchongth
Copy link
Copy Markdown
Member

@aaronchongth aaronchongth commented Feb 20, 2026

What's new

Fixes #1073

  • use generated pydantic model for BeaconState
  • fix stale use of id_

How to test

The Beacons microapp have been deprecated and removed, so we don't have a full code path to test the UI anymore.
Test with commit 5f0051b, which is just the fix with extra lines of DB access similar to how the routes work.

Publish a beacon state using ROS 2 after sourcing the workspace,

ros2 topic pub --once /beacon_state rmf_fleet_msgs/msg/BeaconState "{id: test_beacon, online: true, category: visual, activated: true, level: L1}"

Self-checks

  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Copy link
Copy Markdown
Member Author

CI to pass, waiting for #1077

@aaronchongth aaronchongth moved this from Inbox to In Review in PMC Board Feb 20, 2026
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.65%. Comparing base (ad9f32b) to head (dde46d3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/api-server/api_server/repositories/rmf.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   70.11%   79.65%   +9.54%     
==========================================
  Files         286      142     -144     
  Lines       14190     3038   -11152     
  Branches     1142        0    -1142     
==========================================
- Hits         9949     2420    -7529     
+ Misses       4217      618    -3599     
+ Partials       24        0      -24     
Flag Coverage Δ
api-server 79.65% <66.66%> (-0.04%) ⬇️
rmf-dashboard-framework ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aaronchongth aaronchongth merged commit 8d0c68a into main Feb 23, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in PMC Board Feb 23, 2026
@aaronchongth aaronchongth deleted the fix/1073 branch February 23, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in /beacons endpoints: BeaconState.model_validate(TortoiseModel) raises 500 when DB has rows

3 participants