Fix/1073#1074
Merged
aaronchongth merged 13 commits intomainfrom Feb 23, 2026
Merged
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
1 task
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Member
Author
|
CI to pass, waiting for #1077 |
koonpeng
approved these changes
Feb 23, 2026
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
+ Coverage 70.11% 79.65% +9.54%
==========================================
Files 286 142 -144
Lines 14190 3038 -11152
Branches 1142 0 -1142
==========================================
- Hits 9949 2420 -7529
+ Misses 4217 618 -3599
+ Partials 24 0 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Fixes #1073
BeaconStateid_How to test
The Beacons microapp have been deprecated and removed, so we don't have a full code path to test the UI anymore.
Test with commit 5f0051b, which is just the fix with extra lines of DB access similar to how the routes work.
Publish a beacon state using ROS 2 after sourcing the workspace,
ros2 topic pub --once /beacon_state rmf_fleet_msgs/msg/BeaconState "{id: test_beacon, online: true, category: visual, activated: true, level: L1}"Self-checks