chore(tests): Ensure we terminate Verdaccio#199
Merged
jsteinich merged 1 commit intoMay 26, 2026
Conversation
gabegorelick
commented
May 24, 2026
Verdaccio was introduced in 548aa63 so that tests could install the CLI from an npm registry, similar to how real users install it. Unfortunately, we didn't always kill it after we were done.
gabegorelick
force-pushed
the
local-registry-termination
branch
from
9b30fd5 to
6241720
Compare
gabegorelick
commented
May 24, 2026
Contributor
|
lgtm, but would like @X-Guardian comments |
gabegorelick
commented
May 24, 2026
gabegorelick
commented
May 24, 2026
8 tasks
Contributor
|
Please see this comment: #202 (review) |
jsteinich
approved these changes
May 26, 2026
Contributor
Author
@X-Guardian since there seems to be active discussion around the rewrite of the local-registry script, I think it may be best if we merge this PR first. It's easy for #202 to resolve the conflicts introduced by this PR, since it rewrites all of the local-registry script anyway. |
X-Guardian
approved these changes
May 26, 2026
so0k
added a commit
that referenced
this pull request
Jun 5, 2026
## 0.23.3 ### chore - chore(gha): run integration tests on Depot runners [\#238](#238) - chore(deps): bump typescript to 5.9.3 across the repo [\#231](#231) - chore: Upgrade jsii [\#223](#223) - chore: Revise README links to documentation and language support [\#221](#221) - chore: Pin node version to 22.22.2 via .nvmrc [\#212](#212) - chore: Add gradle cache to the examples and integration CI workflows [\#211](#211) - chore: Add PR workflow concurrency group and CI Label Filter job [\#204](#204) - chore(tests): add verdaccio to package.json [\#202](#202) - chore(tests): don't require other language builds [\#201](#201) - chore(tests): Ensure we terminate Verdaccio [\#199](#199) - chore: rewrite https://cdk.tf links [\#197](#197) - chore: Update examples help files [\#194](#194) ### feat - feat: faster JSON stringify [\#224](#224) - feat(lib): allow disabling creation stacks [\#215](#215) ### fix - fix(lib): surface stderr/stdout on exec() failures via toString() [\#207](#207) --------- Co-authored-by: so0k <vincent.drl@gmail.com> Co-authored-by: sakul-learning <lucas@sheesh.host>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verdaccio was introduced in 548aa63 so that tests could install the CLI from an npm registry, similar to how real users install it. Unfortunately, we didn't always kill it after we were done.
Related issue
Fixes #
Description
Integration tests often leave orphaned verdaccio processes around. This can cause subsequent test runs to fail.
Checklist