fix(mcp): serve dedup flake#972
Conversation
Commit-early sweep: implementer leg ended without committing (build-lane contention). Local gates deferred to CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ky tx-age sweep run_writer_task registers a writer_task_tx handle in the process-wide tx_registry singleton; the checkpoint tx_age_sweep_* tests read that singleton under #[serial(tx_registry)]. The writer_task.rs tests that spawn a writer task were missing from the group, leaking a longer-lived writer_task_tx into the sweep's oldest() read and intermittently failing the assertion on main CI. Join them to the serial group. No prod change.
Validate multi-backend runtime configuration against the anchor captured at construction entry so process-global HOME changes cannot create a TOCTOU mismatch. Add a deterministic regression that fails under the former re-read behavior.
|
Static review: APPROVE at head 8deb5d6. The prior High (TOCTOU on the dedup path) is resolved. Ready for maintainer review. |
Merge main and drop implementation_notes.md, a stray process-notes file that does not belong in the source tree.
oceanwaves630
left a comment
oceanwaves630
left a comment
There was a problem hiding this comment.
APPROVED. Hygiene hold cleared: verified implementation_notes.md is gone from both the PR net diff and the head tree (404). Prior codex APPROVE on the code stands. Sequencing acknowledged: merge #961 first, recheck #967/#972 mergeability and re-merge main if the squash surfaces overlap on serve.rs/writer_task.rs. Squash-merge (drops the phantom code_ingest.rs merge-base artifact regardless). Land the tracked .gitignore for implementation_notes.md on main too — .git/info/exclude covers our worktrees but only a tracked entry protects fresh clones + CI on a public repo.
Keep downstream Option<&str> callers source-compatible while captured boot paths avoid re-reading mutable HOME state.
oceanwaves630
left a comment
oceanwaves630
left a comment
There was a problem hiding this comment.
Fresh review at head bcb4350 (supersedes my earlier approval at a pre-fix head): validation restore confirmed by independent review at this exact head; CI 23/23.
2 participants
Addresses #720.
Implementer leg completed the change set but stalled before commit (shared build-lane contention); swept and pushed by the lane owner. Local gates deferred to CI; codex review follows.
🤖 Generated with Claude Code