fix(comm): prevent silent self-address when sending to parent actor#961
Draft
ohdearquant wants to merge 16 commits into
Draft
fix(comm): prevent silent self-address when sending to parent actor#961ohdearquant wants to merge 16 commits into
ohdearquant wants to merge 16 commits into
Conversation
A send naming an explicit lambda target could resolve to the sender's own inbox when the child session's actor resolution collapsed into the parent identity, delivering the message to the sender silently. A resolved target equal to the sender when the caller named a different target is now an error, never a delivery. Fixes #820 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Commit-early sweep: implementer leg ended without committing (build-lane contention). Local gates deferred to CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ky tx-age sweep run_writer_task registers a writer_task_tx handle in the process-wide tx_registry singleton; the checkpoint tx_age_sweep_* tests read that singleton under #[serial(tx_registry)]. The writer_task.rs tests that spawn a writer task were missing from the group, leaking a longer-lived writer_task_tx into the sweep's oldest() read and intermittently failing the assertion on main CI. Join them to the serial group. No prod change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #820. Tests cover child-to-parent delivery, explicit self-send still allowed, and the silent-collapse case now loud. Local gates deferred to CI due to build-lane contention; codex review follows.