Repository navigation
20261005 - Say the RSPduo notch keys are required, and what each blocks - #78
Merged
Merged
Conversation
The README said dabNotch and rfNotch default to false. blah2 has no default for either: both keys are required. It also did not say which band each notch covers: 155-235 MHz for DAB and 77-115 MHz for AM/FM. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/capture/rspduo/README.mdsaiddabNotchandrfNotchdefault to false. blah2 has no default for either: both keys are required. The README now says so and gives each notch's band (DAB 155-235 MHz, AM/FM 77-115 MHz).Docs only, no code change. It replaces the wording that #77 brought back when reverting #75.
🤖 Generated with Claude Code