feat: consolidated .all-raw-deps file for per-module filtering#14273
Draft
robinbb wants to merge 1 commit intoocaml:robinbb-issue-4572-combined-testsfrom
Draft
feat: consolidated .all-raw-deps file for per-module filtering#14273robinbb wants to merge 1 commit intoocaml:robinbb-issue-4572-combined-testsfrom
robinbb wants to merge 1 commit intoocaml:robinbb-issue-4572-combined-testsfrom
Conversation
5 tasks
Collaborator
Author
|
This seems to have reduced the null build time to 5.9 seconds. |
robinbb
force-pushed
the
robinbb-issue-4572-all-raw-deps
branch
2 times, most recently
from
057219b to
1cc67cc
Compare
Produce a .all-raw-deps file per module in the ocamldep pipeline that contains the union of raw module names (preserving external library references) from the module and all its transitive intra-library deps. This replaces reading N individual .d files during per-module library filtering with a single file read, reducing null-build overhead. The .all-raw-deps file is produced as a separate rule from .all-deps (not combined via Progn) to avoid interfering with cycle detection. It depends on the resolved .all-deps file and chains transitive .all-raw-deps files. Empty files are produced for external virtual library modules that don't have locally-produced dep files. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-issue-4572-all-raw-deps
branch
from
1cc67cc to
4f87a35
Compare
Collaborator
Author
|
Null build is 6.1 seconds, now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Produce a
.all-raw-depsfile per module in the ocamldep pipeline thatcontains the union of raw module names from the module and all its
transitive intra-library deps. This replaces reading N individual
.dfiles during per-module library filtering with a single file read,
reducing null-build overhead.
Depends on #14116.
Test plan