feat: persist filtered library set as build target#14275
Closed
robinbb wants to merge 1 commit intoocaml:robinbb-issue-4572-combined-testsfrom
Closed
feat: persist filtered library set as build target#14275robinbb wants to merge 1 commit intoocaml:robinbb-issue-4572-combined-testsfrom
robinbb wants to merge 1 commit intoocaml:robinbb-issue-4572-combined-testsfrom
Conversation
Write the filtered library names to a .filtered-libs file per module. The compilation rule reads this file to set up deps, instead of computing the filtering inline. On a null build, the .filtered-libs rule is a cache hit (its inputs — .d files — haven't changed), so the filtering computation is skipped entirely. The compilation rule just reads one small file and resolves library names. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
Collaborator
Author
|
Closing in favor of #14273, which achieves the same goal with less complexity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write the filtered library names to a
.filtered-libsfile per module.The compilation rule reads this file to set up deps, instead of computing
the filtering inline in the builder.
On a null build, the
.filtered-libsrule is a cache hit (its inputs —.dfiles — haven't changed), so the filtering computation is skippedentirely. The compilation rule just reads one small file and resolves
library names.
Alternative to #14273 (consolidated
.all-raw-deps). This approachcaches the entire filtering computation (including
Lib.closure), notjust the
.dfile reads.Depends on #14116.
Test plan