fix(app-shell): localize popup-blocked toast and SSO spinner tab copy via i18n (#3321) by xuyushun441-sys · Pull Request #3328 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-04T00:54:26Z

问题

consoleServerAction.ts 的 opensInNewTab 编排里硬编码了中英双语文案，违反 AGENTS.md Commandment #-1（代码库纯英文）。四处文案：

SSO spinner tab 标题：正在打开… Opening…
SSO spinner tab 正文：正在为你打开环境…
popup-blocked toast 标题：浏览器拦截了弹窗 / Popup blocked
toast 描述 点击在新标签页打开环境 + action label 打开环境

方案（采用 issue 评论 PM 预裁决的首选方案：`t` 经 options 注入，非底线纯英文字面量方案——i18n 键位与基建顺畅，无需降级）

t 经 options 注入：createConsoleServerActionHandler 新增可选 t?: ConsoleServerActionTranslate（i18next 风格 t(key, englishDefault)）。包装器是普通函数不能调 hook，两个调用点（useConsoleActionRuntime、RecordDetailView）都有 hook 上下文，用 useObjectTranslation().t 经 env ref 注入——语言切换即时生效，且不打断 handler 实例的稳定性（in-flight guard 依赖同一实例）。
英文默认值兜底：不传 t（测试 / standalone）时全部落到英文默认值；代码里不再有任何非英文文案。
中文进 i18n 资源文件：新增 console.serverAction.* 五个键（openingTitle / openingBody / popupBlockedTitle / popupBlockedDescription / popupBlockedAction），11 个 locale 包全量补齐（en/zh/de/es/fr/ja/ko/pt/ru/ar，all-locales-key-parity 强制对齐）。
顺手一处安全加固：locale 字符串写入 spinner document 前做最小 HTML 转义（escapeHtml），有测试钉住。
措辞去掉「环境」特指：包装器是通用基建（任何 opensInNewTab server action 都走它），原中文「打开环境」是 cloud SSO 场景专属词汇；新文案改为通用表述（"Open in new tab" 等），避免把 cloud 词汇固化进 app-shell。如维护者希望保留「环境」措辞，改 locale 资源文件即可，不用动代码。

验证

项	命令	结果
落点 + 调用点 + parity 测试	仓根 `pnpm exec vitest run --maxWorkers=2` consoleServerAction / actions-envelope.ratchet / useConsoleActionRuntime / RecordDetailView.modalDispatch / all-locales-key-parity / en-zh-key-parity	6 files, 83 tests 全绿（14.75s）
新增文案测试	同上（含 4 个新测试：英文默认值、注入 `t` 走键位（tab + toast）、HTML 转义、无 CJK pin）	绿
破坏验证	临时把 toast 标题与 spinner 正文改回中文 → 恰好 2 个文案 pin 测试红（`opens lazily…toast fallback`、`no CJK in code`，2 failed / 12 passed）→ 还原 → 14/14 绿	✅
lint（改动文件）	`pnpm exec eslint <改动文件>`	0 errors（193 个既有 `no-explicit-any` warning，均非新增行）
type-check（i18n + app-shell）+ 本地全量	被容器重启打断（排队等共享验证锁时容器第三次重启，PM 裁定不再重跑本地全量），交由本 PR 的 CI 把关	⚠️ CI 把关

Changeset

@object-ui/app-shell + @object-ui/i18n 均 patch（fixed group 联动，无 major）。

🤖 Generated with Claude Code

https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

… via i18n (#3321) The opensInNewTab choreography in consoleServerAction.ts shipped hard-coded bilingual Chinese/English copy, violating AGENTS.md Commandment #-1. The four strings (spinner tab title + body, popup-blocked toast title/description/ action label) now route through new console.serverAction.* keys in @object-ui/i18n (all eleven locale packs, key parity kept), injected via an optional i18next-style t option on createConsoleServerActionHandler from the two hook-context call sites; English defaults apply when t is omitted. Locale strings are HTML-escaped before entering the spinner document. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

vercel · 2026-08-04T00:54:32Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 4, 2026 12:55am

…unction Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

github-actions · 2026-08-04T00:59:35Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BXVhb_qJ.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	476.66KB	104.69KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	224.99KB	55.14KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	60.54KB	17.13KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.01KB	28.86KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	230.56KB	56.80KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.25KB	39.55KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	104.94KB	25.32KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.55KB	10.59KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Aug 4, 2026

docs(app-shell): keep preOpenSpinnerTab doc comment attached to its f…

0afb31d

…unction Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

xuyushun441-sys marked this pull request as ready for review August 4, 2026 01:48

xuyushun441-sys added this pull request to the merge queue Aug 4, 2026

Merged via the queue into main with commit a415684 Aug 4, 2026
14 of 16 checks passed

xuyushun441-sys deleted the claude/issue-3321-popup-copy-english branch August 4, 2026 01:48

This was referenced Aug 4, 2026

fix(fields): #3342 TagsField placeholder 走 field.placeholder → i18n → 英文默认三级链，移除硬编码中文 #3350

Merged

Changeset popup-copy-english-i18n.md says "eleven locale packs" — the repo has ten #3351

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(app-shell): localize popup-blocked toast and SSO spinner tab copy via i18n (#3321) - #3328

fix(app-shell): localize popup-blocked toast and SSO spinner tab copy via i18n (#3321)#3328
xuyushun441-sys merged 2 commits into
mainfrom
claude/issue-3321-popup-copy-english

xuyushun441-sys commented Aug 4, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

问题

方案（采用 issue 评论 PM 预裁决的首选方案：t 经 options 注入，非底线纯英文字面量方案——i18n 键位与基建顺畅，无需降级）

验证

Changeset

Uh oh!

vercel Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xuyushun441-sys commented Aug 4, 2026 •

edited

Loading

方案（采用 issue 评论 PM 预裁决的首选方案：`t` 经 options 注入，非底线纯英文字面量方案——i18n 键位与基建顺畅，无需降级）

vercel Bot commented Aug 4, 2026 •

edited

Loading