fix(fields): #3342 TagsField placeholder 走 field.placeholder → i18n → 英文默认三级链，移除硬编码中文 by xuyushun441-sys · Pull Request #3350 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-04T05:52:46Z

问题

packages/fields/src/widgets/TagsField.tsx 的输入框 placeholder 是硬编码中文字符串（输入后回车添加…）：

违反 AGENTS.md Commandment #-1（English-only codebase）；
绕过了同目录其它 widget（SelectField/LookupField）都在走的 useFieldTranslation() i18n 通道；
作者在字段元数据里声明的 field.placeholder 在此 widget 中被完全忽略。

修复（按 issue 评论中的 PM 裁决）

三级优先链，与 SelectField 的 config?.placeholder || t('common.selectOption') 同构：

field.placeholder —— 作者声明永远优先（即使切到非英文 locale 也不被翻译覆盖）；
t('fields.tags.placeholder') —— 经 useFieldTranslation() 从 locale 包取（key 组织对齐 fields.* 既有命名空间，紧邻 fields.options / fields.objectRef）；
英文默认值（FIELD_DEFAULTS）—— 无 I18nProvider 时渲染 Type and press Enter to add…，绝不渲染裸 key。

中文文案进 zh locale 包，代码中不再含 CJK。fields.tags.placeholder 按 #3328（objectui#3321）的方式在全部 10 个 locale 包（en/zh/ja/ko/de/fr/es/pt/ru/ar）补齐 —— 派单里写的"11 个"沿用了 #3328 changeset 的笔误，仓库实际是 10 个包（all-locales-key-parity 测试钉住 OTHER_LOCALES 长度为 9 + en）。

保留原有行为：placeholder 仅在标签列表为空时显示（已有标签时输入框是续接条，提示是噪音）。

验证

项	命令	结果
新增测试（三级链 8 例）	`pnpm exec vitest run packages/fields/src/widgets/TagsField.placeholder.test.tsx packages/fields/src/widgets/TagsField.placeholder.no-provider.test.tsx`	✅ 8 passed
#3345 aria-invalid registry 守卫 + dom-leak 守卫 + locale parity	`pnpm exec vitest run …widget-aria-invalid-registry-e2e… …widget-dom-leak-e2e… …all-locales-key-parity… …en-zh-key-parity…`（连同新增测试共 6 文件）	✅ 312 passed
type-check	`pnpm --filter @object-ui/fields type-check` / `--filter @object-ui/i18n type-check`	✅ 双双通过

破坏验证实录

源码破坏：把 placeholder 改回硬编码中文字面量 → 新测试 6/8 红（en 链、无 provider 英文默认、CJK pin、作者声明优先各案全红；仅 zh-pack 案与"有标签时为空"案因巧合仍绿）→ 还原 → 全绿。
locale 破坏：从 ar 包删除 fields.tags.placeholder → all-locales-key-parity 红（ar is missing 1 key(s): [ 'fields.tags.placeholder' ]）→ 还原 → 20/20 绿。

测试布局说明

no-provider 断言独立成文件（TagsField.placeholder.no-provider.test.tsx），原因与 OptionsEmptyState.no-provider.test.tsx 相同：一旦挂过 I18nProvider，initReactI18next 会把实例装成 react-i18next 全局默认，同一模块图内不再存在"无 provider"状态可观测。Commandment #-1 的 CJK pin 也放在该文件（无 provider 时渲染出的文案必然来自代码，正则用转义 \u 区间以免测试自身携带 CJK 字面量）。

Changeset

@object-ui/fields + @object-ui/i18n 均 patch（fixed group，无 major）。未触碰 content/docs/releases/。

🤖 Generated with Claude Code

https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

Generated by Claude Code

…er → i18n → English default, no hardcoded Chinese The tags widget's input placeholder was a hardcoded Chinese literal (Commandment #-1 violation) and ignored the author-declared field.placeholder. It now resolves through the pinned chain: field.placeholder (author declaration wins) → t('fields.tags.placeholder') via useFieldTranslation() → English FIELD_DEFAULTS fallback when no I18nProvider is mounted. The new key is added at full parity across all ten locale packs; Chinese lives in the zh pack only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

vercel · 2026-08-04T05:52:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 4, 2026 5:52am

github-actions · 2026-08-04T05:56:15Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BiPpfT68.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	476.68KB	104.68KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	226.62KB	55.51KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	60.54KB	17.13KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.01KB	28.86KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	230.61KB	56.81KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.25KB	39.55KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	104.94KB	25.32KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.55KB	10.59KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Aug 4, 2026

xuyushun441-sys mentioned this pull request Aug 4, 2026

Changeset popup-copy-english-i18n.md says "eleven locale packs" — the repo has ten #3351

Open

xuyushun441-sys marked this pull request as ready for review August 4, 2026 06:36

xuyushun441-sys added this pull request to the merge queue Aug 4, 2026

Merged via the queue into main with commit c7ed4c3 Aug 4, 2026
16 checks passed

xuyushun441-sys deleted the claude/issue-3342-tags-placeholder-i18n branch August 4, 2026 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(fields): #3342 TagsField placeholder 走 field.placeholder → i18n → 英文默认三级链，移除硬编码中文 - #3350

fix(fields): #3342 TagsField placeholder 走 field.placeholder → i18n → 英文默认三级链，移除硬编码中文#3350
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-3342-tags-placeholder-i18n

xuyushun441-sys commented Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 4, 2026

问题

修复（按 issue 评论中的 PM 裁决）

验证

破坏验证实录

测试布局说明

Changeset

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants