Skip to content

feat(layout): area 可见性派生自 item 可见性,补掉退役留下的「可见但空」回归 (#3311) - #3322

Merged
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-3311-area-derived-visibility
Aug 3, 2026
Merged

feat(layout): area 可见性派生自 item 可见性,补掉退役留下的「可见但空」回归 (#3311)#3322
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-3311-area-derived-visibility

Conversation

@xuyushun441-sys

@xuyushun441-sys xuyushun441-sys commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #3311

按 #3311 裁决实施选项 C:area 可见性派生自「区域内是否存在至少一个可见 item」,不新增、不复活任何 authorable key。

背景

spec 17.0.0 退役了 area 级 visible / requiredPermissions(AREA_VISIBLE_RETIRED / AREA_REQUIRED_PERMISSIONS_RETIRED),#3315 跟随退役删掉了 AreaSwitcher 的过滤。契约上正确,但留下行为回归:某区域内 item 全部被 gate 掉时,以前整块区域从切换器消失,退役后渲染成「可见但空」的区域,且第一个区域全被 gate 时用户还会被默认落在空区域上。

实现

  • 新增 hasVisibleNavigationItems(items, options)(packages/layout/src/NavigationRenderer.tsx,导出):判定一棵导航树里是否存在至少一个「真的会渲染」的 item。守卫逐条对齐 NavigationItemRenderer 的 item 级判定:visible 表达式(evaluateVisibility)、requiredPermissions(checkPermission)、requiresObject / requiresService(checkCapability)、以及 action 项的 dispatcher 存在性(framework#4509:无 onAction 则不渲染,自然也不能撑起一个区域)。separator 不算内容;group 只经由子项计数,且 group 自身守卫先于递归生效。
  • AppSchemaRenderer 用该谓词过滤区域:AreaSwitcher 只列出可见区域;只剩一个可见区域时不再显示切换器(与退役前 visibleAreas.length <= 1 的语义一致)。
  • 活动区域只在可见区域中选举:初值取第一个可见区域;gating 变化把当前活动区域藏掉时重新选举第一个可见区域;仅仅「新增可见」的变化不会把用户从当前区域拽走。渲染时按有效区域取导航(state 由 effect 同步),避免过渡帧渲染被隐藏区域的空导航。
  • 派生规则由渲染守卫直接计算,不可能与实际渲染结果不一致,元数据作者无从写错 —— 这正是裁决里「把曾经的 authorable 门变成一条不可能说谎的派生规则」。

边界:空区域(本来就没有 item 的 area)

裁决评论定义为「派生自区域内是否存在可见 item」——空区域没有任何 item,自然没有可见 item,按与全被 gate 一致处理(隐藏),已在 issue 认领评论标注、测试 treats an area with no items at all like a fully gated one 钉住。请维护者复核这一边界;若希望空区域仍显示,只需把谓词入口改为对 navigation.length === 0 提前返回 true,一处改动。

#3315 两条 item 级断言的语义更新(需要说明)

AppSchemaRenderer.test.tsx 里 #3315 落的 gates the navigation ITEM by visibility/permission, not the area 原断言「区域仍出现在切换器」——其场景恰是「区域内唯一 item 被 gate」,与本 PR 的派生规则语义相反(那正是要修的回归)。两条测试已改为部分被 gate 的区域(被 gate 的 item + 一个可见兄弟 item):区域保持可见且激活、可见 item 渲染、被 gate 的 item 不渲染 —— item 级 gate 断言依旧承重,「全被 gate 则区域隐藏」由新测试块覆盖。types 侧 #3315 的退役钉子(page-nav-misc-spec-parity.test.ts 等)未动、全绿。

验证

场景 测试 结果
全部区域可见 keeps every area in the switcher when every area has a visible item ✅
部分被 gate(区域显示) 两条改写后的 gates the navigation ITEM … ✅
全被 gate(visibility) → 区域隐藏 + 跳过默认激活 hides an area whose items are ALL gated and activates the first visible area ✅
全被 gate(permission) → 区域隐藏 hides an area whose items all fail their permission checks ✅
只剩一个可见区域 → 不显示切换器 hides the switcher entirely when only one area remains visible ✅
所有区域全被 gate → 无切换器、无区域导航 renders no switcher and no area navigation when every area is fully gated ✅
空区域(边界) treats an area with no items at all like a fully gated one (hidden) ✅
group 递归派生 derives through groups … ✅
gating 条件变化 → 重新选举 / 不拽走用户 re-derives when gating changes … ✅
谓词单测(separator / action dispatcher / capability / group 守卫) hasVisibleNavigationItems describe 块 6 条 ✅

破坏验证(改坏 → 红 → 还原 → 绿)

  • 变异 1:hasVisibleNavigationItems 恒返回 true(派生失效)→ 13 条断言红(7 条派生行为 + 6 条谓词单测)→ 还原后 47/47 绿。
  • 变异 2:活动区域选举全部改回 areas(退役后的旧行为)→ 6 条断言红(区域隐藏 + 重新选举各条)→ 还原后 47/47 绿。
  • 注:仅改坏渲染期兜底(state 选举保留)时断言不红 —— state 选举与渲染期兜底对稳态 DOM 冗余,兜底防的是 effect 提交前的过渡帧(真实浏览器里 effect 在 paint 后运行),故保留。

全量

Out of scope

🤖 Generated with Claude Code

https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

Generated by Claude Code

@claude
feat(layout): derive area visibility from item visibility (#3311)
8edc75f 
Spec 17.0.0 retired the authorable area-level visible/requiredPermissions;
following it in #3315 left a fully gated area rendering as visible-but-empty
in the AreaSwitcher. Per the #3311 ruling (option C), area visibility is now
DERIVED: an area appears in the switcher iff at least one of its items
survives the exact item-level guards NavigationRenderer applies (visible
expression, requiredPermissions, requiresObject/requiresService capability
gates, and the onAction dispatcher presence for action items — framework#4509).
Separators never count; groups count only through their children; an area
with no items at all derives hidden the same way.

The active area is elected among visible areas only, so a fully gated first
area is never auto-activated, and a gating change that hides the active area
re-elects the first visible one — while a change that merely reveals an area
never yanks the user away.

New export: hasVisibleNavigationItems from @object-ui/layout. No authorable
key is involved — nothing for a metadata author to get wrong, and nothing for
the spec's .strict() area object to reject.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Aug 3, 2026 7:16pm

Request Review

@xuyushun441-sys
xuyushun441-sys marked this pull request as ready for review August 3, 2026 19:17
@xuyushun441-sys
xuyushun441-sys added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit 608669e Aug 3, 2026
16 of 17 checks passed
@xuyushun441-sys
xuyushun441-sys deleted the claude/issue-3311-area-derived-visibility branch August 3, 2026 19:17
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.1 KB 350 KB
Entry file index-BTW2X0u4.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.47KB 3.09KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.13KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.64KB 2.21KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 476.66KB 104.69KB
core (index.js) 2.25KB 0.80KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 136.23KB 34.75KB
fields (index.js) 224.93KB 55.15KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 26.14KB 6.07KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.53KB 10.71KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.98KB 12.37KB
plugin-charts (index.js) 60.54KB 17.13KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 112.01KB 28.86KB
plugin-designer (index.js) 210.51KB 42.51KB
plugin-detail (index.js) 230.56KB 56.80KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 111.54KB 26.97KB
plugin-gantt (index.js) 162.25KB 39.55KB
plugin-grid (index.js) 185.08KB 49.04KB
plugin-kanban (index.js) 47.89KB 13.18KB
plugin-list (index.js) 104.94KB 25.32KB
plugin-map (index.js) 16.81KB 5.24KB
plugin-markdown (index.js) 13.72KB 4.69KB
plugin-report (index.js) 40.55KB 10.59KB
plugin-timeline (index.js) 25.76KB 7.33KB
plugin-tree (index.js) 8.34KB 2.82KB
plugin-view (index.js) 83.67KB 20.43KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 4.47KB 2.03KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 2.46KB 1.21KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 3.40KB 1.71KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

This was referenced Aug 4, 2026
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: types tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NavigationArea 的 area 级 visible / requiredPermissions 退役前提也不成立 —— AppSchemaRenderer.AreaSwitcher 一直在按它过滤

2 participants

@xuyushun441-sys @claude