fix(app-shell): AppSidebar / UnifiedSidebar 区域切换器采用派生可见性（#3319） by xuyushun441-sys · Pull Request #3327 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-04T00:43:33Z

问题

packages/app-shell 的 AppSidebar 与 UnifiedSidebar 各自内联了一份区域切换器，均无 area 级过滤：某区域内 item 全被 gate（visible 表达式 / requiredPermissions / requiresObject / requiresService）时，区域仍出现在切换器里，点进去是空的；若第一个区域全被 gate，用户还会被默认落在空区域上。与 #3311 修掉的 AppSchemaRenderer 问题同型。

修法（按 issue 评论中的 PM 裁决逐条）

复用共享谓词，不写第二份判定 — 两处切换器均改为调用 @object-ui/layout 已导出的 hasVisibleNavigationItems：区域可见 iff 其中至少一个 item 能通过 NavigationRenderer 逐条应用的 item 级守卫，切换器与实际渲染永不打架。差异只在 dispatcher：UnifiedSidebar 接了 onAction={dispatchNavAction}（framework#4509），action 项计为内容（hasActionHandler: !!dispatchNavAction）；AppSidebar 未接 onAction，action 项不承重（hasActionHandler: false）。
活动区域只在可见区域中选举 — 默认首个可见区域；当前活动区域被 gate 掉后重新选举；仅「揭示新区域」不夺用户当前选择（effect 中 prev 仍可见即保留）。渲染期另有 ?? visibleAreas[0] 兜底，覆盖 gating 变化与 effect 重选举之间的那一帧。
空区域（本无 item）按 feat(layout): area 可见性派生自 item 可见性,补掉退役留下的「可见但空」回归 (#3311) #3322 口径隐藏 — 派生口径天然一致：无可见 item 即隐藏。
areas: any[] 收紧为 NavigationArea[]（两处）。
不引入任何 authorable key — enforce-or-remove 之后不复活 area 级声明式 gating。

顺带把两组件中 evalVis / checkPerm / checkCap 的定义位置上移到区域管理之前（谓词需要它们），逻辑未改动。

测试

新增两个测试文件（真实 @object-ui/layout + @object-ui/components，仅 mock console providers），两组件各自覆盖：

场景	AppSidebar	UnifiedSidebar
全可见：全部区域在列，首区域激活，可切换	✅	✅
部分 gate：区域保留且激活，仅被 gate 的 item 不渲染	✅	✅
全 gate：区域从切换器消失，选举跳过它落到首个可见区域	✅	✅
仅剩一个可见区域：整个切换器隐藏	✅	✅
全部区域被 gate：无切换器、无区域导航	✅	✅
活动区域被 gate 后重选举；仅揭示不夺选	✅	✅
`action` 项计为区域内容（本侧接了 dispatcher）	—（未接）	✅

破坏验证实录（改坏 → 红 → 还原 → 绿，每次只改一处）：

变异	预期失败的测试	实测
AppSidebar 切换器改回 `areas`（无派生过滤）	全 gate 隐藏 / 单区域隐藏切换器 / 全 gate 无导航 / 重选举	4 失败，其余绿
AppSidebar 选举无视 gating（init/effect/activeArea 用 `areas`）	选举跳过 / 单区域 / 重选举	3 失败，其余绿
AppSidebar effect 永远选第一个可见（夺选）	仅揭示不夺选	1 失败，其余绿
UnifiedSidebar 切换器改回 `areas`	同 AppSidebar 第一条	4 失败，其余绿
UnifiedSidebar `hasActionHandler: false`	action 项承重测试	1 失败，其余绿

验证命令（仓根，均 flock 串行 + heap 上限）：

pnpm exec vitest run packages/app-shell/src/layout/__tests__/AppSidebar.derivedAreaVisibility.test.tsx packages/app-shell/src/layout/__tests__/UnifiedSidebar.derivedAreaVisibility.test.tsx → 2 files / 13 tests 全绿
pnpm exec vitest run --maxWorkers=2 packages/app-shell → 269 files / 2328 passed, 1 skipped
turbo run build --filter=@object-ui/app-shell → 29 tasks successful（app-shell tsc 干净）
turbo run type-check --filter=!@object-ui/site → 77 tasks successful
turbo run lint --filter=@object-ui/app-shell → 0 errors（2131 条既有 warning 为存量基线）
⚠️ 仓根全量 vitest 本地未能跑完：容器今日三次重启，全量验证任务三次被杀（PM 裁定不再重跑本地全量），交由本 PR 的 CI 把关。 以上 scoped 结果（含 app-shell 全包 269 文件）均为重启前真实产出。

Changeset

.changeset/app-shell-sidebars-derived-area-visibility.md — @object-ui/app-shell: patch（fixed group，无 major）。未触碰 content/docs/releases/。

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-D3jyhVs9.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	476.66KB	104.69KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	224.99KB	55.14KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	60.54KB	17.13KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.01KB	28.86KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	230.56KB	56.80KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.25KB	39.55KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	104.94KB	25.32KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.55KB	10.59KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

claude added 2 commits August 4, 2026 00:29

chore: changeset for #3319 sidebar derived area visibility

428db06

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

github-actions Bot added the tests label Aug 4, 2026

xuyushun441-sys marked this pull request as ready for review August 4, 2026 01:48

xuyushun441-sys added this pull request to the merge queue Aug 4, 2026

Merged via the queue into main with commit 8d9984c Aug 4, 2026
14 of 16 checks passed

xuyushun441-sys deleted the claude/issue-3319-sidebar-derived-visibility branch August 4, 2026 01:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(app-shell): AppSidebar / UnifiedSidebar 区域切换器采用派生可见性（#3319） - #3327

fix(app-shell): AppSidebar / UnifiedSidebar 区域切换器采用派生可见性（#3319）#3327
xuyushun441-sys merged 2 commits into
mainfrom
claude/issue-3319-sidebar-derived-visibility

xuyushun441-sys commented Aug 4, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

问题

修法（按 issue 评论中的 PM 裁决逐条）

测试

Changeset

相关

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xuyushun441-sys commented Aug 4, 2026 •

edited

Loading