Skip to content

docs: align README/copilot pages with the shipped skills-only surface (#589) - #611

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-589-docs-alignment
Aug 2, 2026
Merged

docs: align README/copilot pages with the shipped skills-only surface (#589)#611
os-zhuang merged 1 commit into
mainfrom
claude/issue-589-docs-alignment

Conversation

@os-zhuang

@os-zhuang os-zhuang commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #589

Description

纯文档变更,不触碰任何 metadata。本 PR 解决四类文档漂移:README 自相矛盾的数量、把已退役 agent 当作在售能力描述的已发布页面、缺少免责声明的归档对比文档,以及过时的架构文档。

所有数字均以当前 origin/mainobjectstack.config.ts 为准,并由 pnpm validate 的输出复核。

Type of Change

  • Documentation update

Related Issues

Fixes #589
Related to #512 (agent 退役), #607 (defaultAgent 改绑平台 ask), #606 (live-schema 演示路径 —— 不在本 PR 范围)

Changes Made

1. README 数字统一

README.md:8:60 声称 "2 AI agents (sales-copilot, service-copilot)、20 flows、5 sharing rules",而同一文件 :131 的仓库结构块正确地写着 skills-only surface, no agents23 flows。真实数字取自 objectstack.config.ts

旧值 实际
app 自有 agents 2 0(skills 附着于平台 ask
skills 6 6 ✓
flows 20 23
sharing rules 5 9(5 条单规则 + 2 条 territory + 2 条 campaign leadership)
datasets 未列 8(补入,使两处清单一致)

pnpm validate 输出复核:15 Objects · 23 Flows · 4 Dashboards · 13 Actions · 12 Positions · 6 Permissions

2. copilot 页面改写为技能文档(6 个页面 + 关联页)

ai-copilot/{sales,service}-copilot.mdx(en / zh-Hans / zh-Hant)此前描述的是 #512 已退役的两个人格化 agent,例如 "It lives in the right-side chat panel and as inline buttons on lead, contact, account, and opportunity pages" —— 那些内联按钮并不存在。

按 issue 的要求改写而非删除URL 保持不变/docs/ai-copilot/sales-copilot 等),避免站内外链接失效;仅 title 改为 Sales Skills / Service Skills / 销售技能 / 銷售技能。新内容全部有源可依:

  • 激活规则取自各 skill 真实的 triggerConditions —— lead_qualificationcrm_leadrevenue_forecastingcrm_opportunitydashboardcase_triagecrm_caselive_data / email_drafting / customer_360 无限制。
  • 写入路径按 ADR-0109 写成 skill 调用的真实 HotCRM Action(convert_leadschedule_followupescalate_caseclose_case),取代原先虚构的 🎯 Qualify / 🚦 Triage / 📚 Find articles 按钮。
  • 每页顶部保留一段"人格设定去哪了"的说明,让老读者能对上号。

连带修正的页面:ai-copilot/index("两个 Copilot" → 一个平台助手 + 六项技能的两种分组)、ai-copilot/skillsai-copilot/knowledge-basesUsed by 列、reference/glossaryAgent (AI) 条目(原文直接断言 "The Sales Copilot and Service Copilot are agents")、customization/ai-skills(原文让开发者去编辑早已删除的 src/agents/sales-copilot.agent.ts,现改为导出 + 加入 allSkills),以及 sales/service/analytics/guides/getting-started/ 中全部指向这两页的链接文案。三语言同步。

content/docs/ai-copilot/live-schema.*scripts/wow1-live-schema.sh 一行未动 —— 那是 #606 的范围。本 PR 的改写没有新增与其冲突的断言:新文案只陈述"能力以 skills 形式挂在平台助手上"这一 #607 已落地的事实。

3. 归档对比文档加退役横幅

docs/archive/2026-02/SALESFORCE_FEATURE_COMPARISON.md 描述的是 ~148 个对象、13 个 package 的另一套架构,把 sla_policy / queue / email_to_case / pricebook 标为"✅ Implemented"(当前树中一个都不存在),并宣称 ~95% Salesforce 功能对等。文件虽已归档但无任何提示,任何评估本仓库的人都会被误导。现以醒目横幅开头,说明它描述的是 pre-2.x 退役架构,并给出当前产品的真实规模与 README / ARCHITECTURE 的指引。

4. docs/ARCHITECTURE.md 去陈旧化

  • mermaid 图删掉已删除的 src/agents 与从未存在的 src/cubes,Analytics 分支改为 src/datasets, src/dashboards, src/reports
  • manifest 表 1.0.52.2.2,并补上 engines.protocol
  • requires 列表移除 ai(2.2.0 移除;ObjectStack 16 下它是 fail-fast 能力,声明会直接让开源版 objectstack start 启动中止),并附上原因说明。
  • 同文件另两处陈旧:Security 区注册字段 rolespositions,以及指向不存在的 src/sharing/role-hierarchy.ts —— 按 ADR-0090 D3 改为 src/sharing/positions.ts 并说明层级已移除。

Testing

  • Unit tests pass — pnpm testTest Files 34 passed (34),Tests 652 passed | 1 skipped (653),含 test/docs-drift.test.ts 的仓库树漂移守卫(TREE_DOCS 覆盖 README.md 与 docs/ARCHITECTURE.md)
  • Linting passes — pnpm lint1 warning(s), 13 suggestion(s),与 base 一致,无新增
  • Build succeeds — pnpm build✓ Build completedist/objectstack.json (1014.1 KB)
  • pnpm validate✓ Validation passed (1074ms)
  • pnpm typecheck:无输出(通过)
  • New tests added — 不适用:纯文档变更,无行为改动;现有的 docs-drift 守卫已覆盖本 PR 触及的两个 TREE_DOCS 文件

Checklist

  • I have added a changeset.changeset/docs-align-retired-agents.md(patch)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Additional Notes

范围之外的发现,已单独立 issue #612(未在本 PR 修复,遵循 Prime Directive #10):

  1. objectstack.config.ts:76 的注释仍写着 "the two agents + skills still validate" —— 同一类漂移,但属于源码文件而非文档。
  2. docs/RELEASE_STRATEGY.md:14 仍写 Current version | 1.0.5(实际 2.2.2)。
  3. content/docs/ 下另有约 39 个产品页面(sales / service / revenue / reference / whats-new)在散文中把 "Sales Copilot" / "Service Copilot" 当作助手昵称使用(共约 90 处)。issue Docs alignment: README/copilot pages describe retired agents; archived Salesforce comparison lacks a retired-architecture banner #589 的问题 2 明确只列举了 ai-copilot/{sales,service}-copilot.mdx 这 6 个页面,且这批文件与 Wow #1 demo docs + script still POST the retired sales_copilot agent #606 的范围有重叠,因此把全站改名作为独立议题另行处理更安全。这些散文并未断言存在名为 sales_copilot 的 agent,因此本 issue 的验收标准"没有已发布页面把 sales_copilot/service_copilot 描述为在售 agent"已经满足。

content/docs/whats-new.mdx"What's in v1.0" 小节提到 Sales Copilot —— 该节是历史发布记录,与 CHANGELOG 同属史料,故保留(仅把中文版首屏现在时的营销文案 "向 Sales Copilot 询问" 与英文版对齐为"向助手询问")。

…#589)

The README claimed "2 AI agents (sales-copilot, service-copilot), 20 flows,
5 sharing rules" seventy lines above a layout block that correctly described a
skills-only surface with 23 flows. Both now state the numbers that
objectstack.config.ts actually registers: 0 app-owned agents, 6 skills, 23
flows, 9 sharing rules, 8 datasets.

Rewrite the six published copilot pages (en/zh-Hans/zh-Hant) as skill docs at
their existing URLs. The personas were retired in #512; the capability ships as
six skills on the platform `ask` assistant. Activation is documented from each
skill's real triggerConditions, and writes are named as the HotCRM actions the
skills call (convert_lead, schedule_followup, escalate_case, close_case)
instead of inline buttons that do not exist.

Follow the rename through the AI Copilot index, the Skills and Knowledge Bases
pages, the glossary's "Agent (AI)" entry, the customization guide (which told
developers to edit the long-deleted src/agents/sales-copilot.agent.ts) and every
inbound link label. live-schema.* is left untouched — it is #606's scope.

Banner the archived Salesforce comparison: it describes a ~148-object,
13-package architecture and marks sla_policy/queue/email_to_case/pricebook as
implemented when none exist, so its "~95% parity" headline misled anyone
evaluating the repo.

Correct docs/ARCHITECTURE.md: drop the deleted src/agents and the never-created
src/cubes from the diagram, 1.0.5 -> 2.2.2, and remove the `ai` capability from
`requires` (removed in 2.2.0 because it is fail-fast under ObjectStack 16).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019SS7C5SXpniKeCApxgARyf
@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hotcrm Ignored Ignored Aug 2, 2026 11:29am

Request Review

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 2, 2026
@os-zhuang
os-zhuang marked this pull request as ready for review August 2, 2026 11:32
@os-zhuang
os-zhuang added this pull request to the merge queue Aug 2, 2026
Merged via the queue into main with commit 2e373d7 Aug 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs alignment: README/copilot pages describe retired agents; archived Salesforce comparison lacks a retired-architecture banner

2 participants