Repository navigation
Conversation
…H_A harness Bumps the opendbc submodule to JamesL787/opendbc@nrdr-bare (5e47e8fe), which ports the 16-slot Bosch-A radar decoder from night-star-bosch-radar and wires it in for the full HONDA_BOSCH_A harness category -- see that commit for details. Also adds the HondaBoschARadar param key (default on) here since this branch's params_keys.h lives in the openpilot repo itself, not the submodule. No prebuilt binaries to rebuild here -- this branch's Params class is a ctypes wrapper around libparams_c (built from openpilot/common/params_c.cc), not a committed prebuilt, so the params_keys.h source change alone is sufficient once this branch is built normally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 of 3 tasks
Owner
|
Added into nrdr-development-new. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HONDA_BOSCH_Aharness category. See that PR for the actual decoder/wiring changes.HondaBoschARadarparam key (default on) toparams_keys.h. No prebuilt binary to update — this branch'sParamsclass is a ctypes wrapper aroundlibparams_c, built fresh from source on every build, not a committed artifact..gitmodulescurrently points the opendbc submodule at my fork (JamesL787/opendbc) since the submodule commit only exists there until honda: port Bosch-A 16-slot radar decoder, enable for full HONDA_BOSCH_A harness opendbc#1 merges. Happy to flip it back tonrdr/opendbcin a follow-up once that lands, or update it now if you'd prefer.Test plan
nrdr/opendbcdirectly🤖 Generated with Claude Code