Repository navigation
Conversation
is_bosch_a_radar_car() and its downstream handling in radard.py never landed alongside the Bosch-A radar decoder (from #16, pending merge into nrdr/opendbc) -- without it, the newly-decoded Bosch-A radar points feed into radard's generic path, which assumes the wrong Kalman filter timestep and is missing a real staleness/freshness gate this radar's actual cadence needs. Ports (unmodified in behavior, renamed to this repo's HONDA_BOSCH_A naming instead of "civic_bosch"): - Kalman filter dt selected from the radar's real ~15Hz cadence (HONDA_BOSCH_A_RADAR_TS), not the ~20Hz model-cycle default - measurement_update gating so a duplicate radarTracks payload (radar runs slower than the model loop) isn't absorbed twice by the KF - a "preferred track" continuity path: a previously-selected lead stays selected through ordinary model-probability fluctuations as long as it's still coherent, instead of re-arbitrating from scratch every cycle - staleness detection with two independent triggers (a better-scoring challenger track sustained over several cycles, or gross absolute-range disagreement with the model sustained over several cycles) that drops a stale preferred track rather than holding it indefinitely - honda_bosch_a_low_speed_radar_lead_sane(), requiring a few real sweeps before a radar-only low-speed takeover Purely additive relative to this file's current content -- all other car behavior is untouched. Tested on the branch this was developed on (109/109 relevant tests pass); this port is a mechanical, unmodified transplant -- worth a run through this repo's own test suite before merge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code