fix(view): restore column width after fullscreen - #22
Closed
nerdislb wants to merge 1 commit into
Closed
Conversation
Author
|
Closing in favor of #19, which predates this PR and addresses the same column-maximize/fullscreen state transition. The approaches differ slightly: #19 preserves column maximize across a fullscreen round trip, while this PR restored the pre-maximize width immediately when leaving fullscreen. Preserving maximize matches Niri and keeps the maximize toggle available for the explicit restore, so #19 is the better upstream direction. I added the reproducible headless coverage here after confirming the bug in a native session; I have shared those findings on #19 in case the regression check is useful there. |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widthFracat1.0after fullscreen exitsReproduction
window-toggle-maximize.window-toggle-fullscreentwice.clearFullWidthState()discardedsavedWidthFracbut intentionally left the currentwidthFracunchanged. Using the existing toggle path restores the saved fraction before fullscreen takes over.Verification
meson test -C build-pr --print-errorlogs(19/19 passed)./tests/harness/verify.sh build-pr/umbriel 170_fullscreen_restore_width -vOriginally found and verified during nbshell integration testing with Zen Browser.