fix: preserve column maximize across fullscreen / maximize-to-edges - #19
fix: preserve column maximize across fullscreen / maximize-to-edges#19Yocraft-2000 wants to merge 1 commit into
Conversation
|
Confirmed independently in a native Umbriel session with Zen Browser. The failure comes from the same state transition this PR changes: entering fullscreen from a full-width scrolling column discards/restores column-maximize state inconsistently, leaving I initially opened #22 before noticing this PR. That alternative restored the saved width immediately when leaving fullscreen, but preserving column maximize as proposed here matches Niri better: fullscreen can round-trip back to maximized, and a subsequent maximize toggle restores the original width. I closed #22 in favor of this PR. I also built a contained headless regression check using a real Wayland client. A useful assertion sequence for this approach would be:
All 19 unit tests passed during the related verification. Happy to contribute/adapt the harness check if useful. |
Summary
Preserve column maximize when toggling fullscreen or maximize-to-edges.
I tried to add some restore etc but I figured I only need to remove these. I'm not sure about this, it is kinda intended but breaks the maximize, and idk why it would be better to unmaximize when leaving fullscreen.
Also with the fix the behavior is the same as in niri and I have no issues.
Motivation
When toggling fullscreen or maximize-to-edges while the window is maximized, it breaks the toggle-maximize bind. It becomes impossible to unmaximize with the bind.
Type of Change
Related Issue
Testing
Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.Additional Notes